From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
benjamin.tissoires@redhat.com, bjorn.andersson@linaro.org,
lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
agross@kernel.org, david.brown@linaro.org, hdegoede@redhat.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] HID: quirks: Refactor ELAN 400 and 401 handling
Date: Wed, 12 Jun 2019 16:45:11 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1906121644160.27227@cbobk.fhfr.pm> (raw)
In-Reply-To: <20190612003507.GG143729@dtor-ws>
On Tue, 11 Jun 2019, Dmitry Torokhov wrote:
> > +static const char *hid_elan_i2c_ignore[] = {
>
> If this is a copy of elan whitelist, then, if we do not want to bother
> with sharing it in object form (as a elan-i2c-ids module), can we at
> least move it into include/linux/input/elan-i2c-ids.h and consume from
> hid-quirks.c?
Let's just not duplicate it in both objects. Why not properly export it
from hid_quirks?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-06-12 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 16:10 [PATCH v5 0/3] Basic DT support for Lenovo Miix 630 Jeffrey Hugo
2019-06-06 16:13 ` [PATCH v5 1/3] Input: elan_i2c: Add comment about link between elan_i2c and hid-quirks Jeffrey Hugo
2019-06-06 16:13 ` [PATCH v5 2/3] HID: quirks: Refactor ELAN 400 and 401 handling Jeffrey Hugo
2019-06-12 0:35 ` Dmitry Torokhov
2019-06-12 14:29 ` Jeffrey Hugo
2019-06-12 14:37 ` Lee Jones
2019-06-12 14:48 ` Jeffrey Hugo
2019-06-12 14:45 ` Jiri Kosina [this message]
2019-06-12 15:13 ` Dmitry Torokhov
2019-06-12 15:21 ` Benjamin Tissoires
2019-06-12 15:38 ` Jeffrey Hugo
2019-06-06 16:13 ` [PATCH v5 3/3] arm64: dts: qcom: Add Lenovo Miix 630 Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1906121644160.27227@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=agross@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).