From: Takashi Iwai <tiwai@suse.de> To: Scott Branden <scott.branden@broadcom.com> Cc: Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Brown <david.brown@linaro.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Shuah Khan <shuah@kernel.org>, bjorn.andersson@linaro.org, Shuah Khan <skhan@linuxfoundation.org>, Arnd Bergmann <arnd@arndb.de>, "Rafael J . Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>, Olof Johansson <olof@lixom.net>, Andrew Morton <akpm@linux-foundation.org>, Dan Carpenter <dan.carpenter@oracle.com>, Colin Ian King <colin.king@canonical.com>, Kees Cook <keescook@chromium.org>, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/7] firmware: add offset to request_firmware_into_buf Date: Mon, 26 Aug 2019 17:20:52 +0200 Message-ID: <s5hr258j6ln.wl-tiwai@suse.de> (raw) In-Reply-To: <10461fcf-9eca-32b6-0f9d-23c63b3f3442@broadcom.com> On Fri, 23 Aug 2019 21:44:42 +0200, Scott Branden wrote: > > Hi Takashi, > > Thanks for review. comments below. > > On 2019-08-23 3:05 a.m., Takashi Iwai wrote: > > On Thu, 22 Aug 2019 21:24:46 +0200, > > Scott Branden wrote: > >> Add offset to request_firmware_into_buf to allow for portions > >> of firmware file to be read into a buffer. Necessary where firmware > >> needs to be loaded in portions from file in memory constrained systems. > > AFAIU, this won't work with the fallback user helper, right? > Seems to work fine in the fw_run_tests.sh with fallbacks. But how? You patch doesn't change anything about the fallback loading mechanism. Or, if the expected behavior is to load the whole content and then copy a part, what's the merit of this API? > > Also it won't work for the compressed firmware files as-is. > Although unnecessary, seems to work fine in the fw_run_tests.sh with > "both" and "xzonly" options. This looks also suspicious. Loading a part of the file from the middle and decompression won't work together, from obvious reasons. If the test passes, it means that the test itself is more likely incorrect, I'm afraid. thanks, Takashi
next prev parent reply index Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-22 19:24 [PATCH 0/7] firmware: add partial read support in request_firmware_into_buf Scott Branden 2019-08-22 19:24 ` [PATCH 1/7] fs: introduce kernel_pread_file* support Scott Branden 2019-08-23 12:29 ` Takashi Iwai 2019-08-23 19:55 ` Scott Branden 2019-08-23 21:29 ` Luis Chamberlain 2019-08-22 19:24 ` [PATCH 2/7] firmware: add offset to request_firmware_into_buf Scott Branden 2019-08-22 19:47 ` Luis Chamberlain 2019-08-22 20:07 ` Scott Branden 2019-08-22 21:12 ` Luis Chamberlain 2019-08-22 23:30 ` Scott Branden 2019-08-23 15:47 ` Luis Chamberlain 2019-08-23 20:16 ` Scott Branden 2019-08-23 10:05 ` Takashi Iwai 2019-08-23 19:44 ` Scott Branden 2019-08-26 15:20 ` Takashi Iwai [this message] 2019-08-26 15:41 ` Scott Branden 2019-08-26 15:57 ` Takashi Iwai 2019-08-26 17:12 ` Takashi Iwai 2019-08-26 17:24 ` Scott Branden 2019-08-27 10:40 ` Takashi Iwai 2019-10-11 13:31 ` Luis Chamberlain 2020-02-21 0:11 ` Scott Branden 2020-02-21 8:44 ` Arnd Bergmann 2020-02-21 18:23 ` Scott Branden 2020-02-21 23:37 ` Scott Branden 2020-02-22 8:06 ` Arnd Bergmann 2019-08-22 19:24 ` [PATCH 3/7] test_firmware: add partial read support for request_firmware_into_buf Scott Branden 2019-08-22 19:24 ` [PATCH 4/7] selftests: firmware: Test partial file reads of request_firmware_into_buf Scott Branden 2019-08-22 19:24 ` [PATCH 5/7] bcm-vk: add bcm_vk UAPI Scott Branden 2019-08-27 13:54 ` Arnd Bergmann 2019-08-27 14:49 ` Kieran Bingham 2019-10-08 15:59 ` Olof Johansson 2019-08-22 19:24 ` [PATCH 6/7] misc: bcm-vk: add Broadcom Valkyrie driver Scott Branden 2019-08-27 14:14 ` Arnd Bergmann 2019-08-27 15:25 ` Nicolas Dufresne 2019-08-22 19:24 ` [PATCH 7/7] MAINTAINERS: bcm-vk: Add maintainer for Broadcom Valkyrie Driver Scott Branden
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5hr258j6ln.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bjorn.andersson@linaro.org \ --cc=colin.king@canonical.com \ --cc=dan.carpenter@oracle.com \ --cc=david.brown@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=keescook@chromium.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=olof@lixom.net \ --cc=rafael@kernel.org \ --cc=scott.branden@broadcom.com \ --cc=shuah@kernel.org \ --cc=skhan@linuxfoundation.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \ linux-arm-msm@vger.kernel.org public-inbox-index linux-arm-msm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git