From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i6SgMMrt" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49243171E for ; Fri, 8 Dec 2023 12:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702067996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BZ2jOncrEKw232jrvqkJsjD/GwaaXlY1Y1umyeZKqBI=; b=i6SgMMrtHYVURDgykMaa8h50mkq7I+5H/xSO7G0mxuwD+lNzeGEkDtGEwCTg21114ajPKq GxhNRNjkdmKFLeuINcZpp4FqTsRZ8y4ugMtrtYnYKiWLD1GMRTyWHwLyTRLs8/6QHNUTVu ZgiRRUVAt0VJBZSE93lecKfFwj8Gv6U= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-adBxgkPaOR2-OPlegdd0vg-1; Fri, 08 Dec 2023 15:39:55 -0500 X-MC-Unique: adBxgkPaOR2-OPlegdd0vg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-77d7d33b126so231137185a.2 for ; Fri, 08 Dec 2023 12:39:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702067993; x=1702672793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BZ2jOncrEKw232jrvqkJsjD/GwaaXlY1Y1umyeZKqBI=; b=MQbShKcryoQGFQYhZapCZVpaZPbpqZESjFvYynJh/YVw9adwCp1VmfYghZYG2CbCm+ lkNW9McoGQG4IZDtKJHjIbmpErnILucF/kNYmn/898U93kIcxiubwvSlKUOP+ws75voU u8gF1tJZsn8DOQazKH6wfBOmdCV8IrLPZB3AwiaQPYjQ1caaPVsbWzMa2EYQpctjh08N lXo8Yz7rDdvcbPM9+VIVajk5hHllIWGYrCNLeiZW5cWkjj6x6JpodCj46/34SngMcETI YMa9bckfXLBbnXvSwtXuYI/vkuQBNX/sF59kgn2B+4VD+yNElpmdRaY6t97LYdv9X5mN XquQ== X-Gm-Message-State: AOJu0YzDkxNdKjG1ymWd4PWrClPA7G2uFN1klLW69elEJ1Wj0wKvJQaY KYTHKXhdSGkuwaae0MArJGTi+F+kESyhMVmfbPUWrRXhW6zJa7IjbjoKIN8eCp+CmcAdw+orUfj YqCH7AW0xFrpmlJukxhhssXj4eS4uSXRCHQ== X-Received: by 2002:a05:620a:4628:b0:77f:3b42:d9ce with SMTP id br40-20020a05620a462800b0077f3b42d9cemr760942qkb.85.1702067993656; Fri, 08 Dec 2023 12:39:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKxCtQsMQxp/KSOFjCeDbaxYduu4LWKBh1Y0Dagd3wlsrQ4MNeu6AtBDd9TCnEjArfrpOATw== X-Received: by 2002:a05:620a:4628:b0:77f:3b42:d9ce with SMTP id br40-20020a05620a462800b0077f3b42d9cemr760936qkb.85.1702067993423; Fri, 08 Dec 2023 12:39:53 -0800 (PST) Received: from fedora ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id o1-20020a05620a228100b00775bb02893esm941499qkh.96.2023.12.08.12.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 12:39:52 -0800 (PST) Date: Fri, 8 Dec 2023 14:39:50 -0600 From: Andrew Halaney To: Manivannan Sadhasivam Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_nitirawa@quicinc.com Subject: Re: [PATCH v2 00/17] scsi: ufs: qcom: Code cleanups Message-ID: References: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> On Fri, Dec 08, 2023 at 12:28:45PM +0530, Manivannan Sadhasivam wrote: > Hello, > > This series has code some cleanups to the Qcom UFS driver. No functional > change. In this version, I've removed code supporting legacy controllers > ver < 2.0, as the respective platforms were never supported in upstream. > > Tested on: RB5 development board based on Qcom SM8250 SoC. > > - Mani > > Changes in v2: > > * Collected review tags > * Fixed the comments from Andrew > * Added a few more patches, most notably one removing the code for old > controllers (ver < v2.0) > I took this for a spin on sa8775p-ride when developing another patch today with no issues. Certainly doesn't hit all the cases here, but: Tested-by: Andrew Halaney # sa8775p-ride > Manivannan Sadhasivam (17): > scsi: ufs: qcom: Use clk_bulk APIs for managing lane clocks > scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() > scsi: ufs: qcom: Fix the return value when > platform_get_resource_byname() fails > scsi: ufs: qcom: Remove superfluous variable assignments > scsi: ufs: qcom: Remove the warning message when core_reset is not > available > scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make > use of them > scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset > fails > scsi: ufs: qcom: Check the return value of > ufs_qcom_power_up_sequence() > scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() > failure > scsi: ufs: qcom: Use dev_err_probe() to simplify error handling of > devm_gpiod_get_optional() > scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array > scsi: ufs: qcom: Sort includes alphabetically > scsi: ufs: qcom: Initialize cycles_in_1us variable in > ufs_qcom_set_core_clk_ctrl() > scsi: ufs: qcom: Simplify ufs_qcom_{assert/deassert}_reset > scsi: ufs: qcom: Remove support for host controllers older than v2.0 > scsi: ufs: qcom: Use ufshcd_rmwl() where applicable > scsi: ufs: qcom: Remove unused definitions > > drivers/ufs/core/ufshcd.c | 6 +- > drivers/ufs/host/ufs-qcom.c | 377 +++++------------------------------- > drivers/ufs/host/ufs-qcom.h | 52 +---- > include/ufs/ufshcd.h | 2 + > 4 files changed, 66 insertions(+), 371 deletions(-) > > -- > 2.25.1 >