From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: agross@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
martin.peterson@oracle.com, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs-qcom: Make structure ufs_hba_qcom_vops constant
Date: Mon, 19 Aug 2019 22:18:18 -0400 [thread overview]
Message-ID: <yq1zhk4y3yt.fsf@oracle.com> (raw)
In-Reply-To: <20190819075557.1547-1-nishkadg.linux@gmail.com> (Nishka Dasgupta's message of "Mon, 19 Aug 2019 13:25:57 +0530")
Nishka,
> Static structure ufs_hba_qcom_vops, of type ufs_hba_variant_ops, is used
> only once, when it is passed as the second argument to function
> ufshcd_pltfrm_init(). In the definition of ufshcd_pltfrm_init(), its
> second parameter (corresponding to ufs_hba_qcom_vops) is declared as
> constant. Hence declare ufs_hba_qcom_vops itself constant as well to
> protect it from unintended modification.
> Issue found with Coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-08-20 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:55 [PATCH] scsi: ufs-qcom: Make structure ufs_hba_qcom_vops constant Nishka Dasgupta
2019-08-19 8:25 ` Vivek Gautam
2019-08-20 2:18 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhk4y3yt.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.peterson@oracle.com \
--cc=nishkadg.linux@gmail.com \
--cc=pedrom.sousa@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).