From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
bauerman@linux.ibm.com, nayna@linux.ibm.com, sgrubb@redhat.com,
paul@paul-moore.com
Cc: rgb@redhat.com, linux-integrity@vger.kernel.org,
linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] integrity: Add errno field in audit message
Date: Thu, 18 Jun 2020 14:10:04 -0400 [thread overview]
Message-ID: <1592503804.4615.47.camel@linux.ibm.com> (raw)
In-Reply-To: <8b3c99b9-6691-5ae2-a287-a22a2c801c59@linux.microsoft.com>
On Thu, 2020-06-18 at 11:05 -0700, Lakshmi Ramasubramanian wrote:
> On 6/18/20 10:41 AM, Mimi Zohar wrote:
>
> >
> > For the reasons that I mentioned previously, unless others are willing
> > to add their Reviewed-by tag not for the audit aspect in particular,
> > but IMA itself, I'm not comfortable making this change all at once.
> >
> > Previously I suggested making the existing integrity_audit_msg() a
> > wrapper for a new function with errno. Steve said, "We normally do
> > not like to have fields that swing in and out ...", but said setting
> > errno to 0 is fine. The original integrity_audit_msg() function would
> > call the new function with errno set to 0.
>
> If the original integrity_audit_msg() always calls the new function with
> errno set to 0, there would be audit messages where "res" field is set
> to "0" (fail) because "result" was non-zero, but errno set to "0"
> (success). Wouldn't this be confusing?
>
> In PATCH 1/2 I've made changes to make the "result" parameter to
> integrity_audit_msg() consistent - i.e., it is always an error code (0
> for success and a negative value for error). Would that address your
> concerns?
You're overloading "res" to imply errno. Define a new parameter
specifically for errno.
Mimi
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2020-06-18 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 20:44 [PATCH 1/2] IMA: pass error code in result parameter to integrity_audit_msg() Lakshmi Ramasubramanian
2020-06-17 20:44 ` [PATCH 2/2] integrity: Add errno field in audit message Lakshmi Ramasubramanian
2020-06-17 21:15 ` Paul Moore
2020-06-17 22:36 ` Steve Grubb
2020-06-18 17:41 ` Mimi Zohar
2020-06-18 18:05 ` Lakshmi Ramasubramanian
2020-06-18 18:10 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592503804.4615.47.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).