From: He Zhe <zhe.he@windriver.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linux-audit@redhat.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat
Date: Tue, 20 Apr 2021 16:38:35 +0800 [thread overview]
Message-ID: <1e55d2b5-4b6e-7fa2-4851-06cac7defb50@windriver.com> (raw)
In-Reply-To: <20210416094324.GA1962@redhat.com>
On 4/16/21 5:43 PM, Oleg Nesterov wrote:
> On 04/16, He Zhe wrote:
>> --- a/arch/arm64/include/asm/syscall.h
>> +++ b/arch/arm64/include/asm/syscall.h
>> @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task,
>> static inline long syscall_get_return_value(struct task_struct *task,
>> struct pt_regs *regs)
>> {
>> - return regs->regs[0];
>> + long val = regs->regs[0];
>> +
>> + if (is_compat_thread(task_thread_info(task)))
>> + val = sign_extend64(val, 31);
>> +
>> + return val;
>> }
> I can't really review these arm-specific patches, but with this change both
> syscall_get_error() and is_syscall_success() can use syscall_get_return_value()
> to avoid the code duplication.
Thanks. I'll improve this if v2 is needed.
Regards,
Zhe
>
> Oleg.
>
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-04-20 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 7:55 [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat He Zhe
2021-04-16 7:55 ` [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat He Zhe
2021-04-16 9:43 ` Oleg Nesterov
2021-04-20 8:38 ` He Zhe [this message]
2021-04-21 17:41 ` Mark Rutland
2021-04-22 16:55 ` Mark Rutland
2021-04-16 7:55 ` [PATCH 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit He Zhe
2021-04-16 12:33 ` [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Catalin Marinas
2021-04-16 13:34 ` Mark Rutland
2021-04-17 13:19 ` David Laight
2021-04-19 12:19 ` Will Deacon
2021-04-20 8:54 ` He Zhe
2021-04-21 17:10 ` Mark Rutland
2021-04-22 16:07 ` Will Deacon
2021-04-22 16:42 ` Mark Rutland
2021-04-22 18:57 ` Dmitry V. Levin
2021-04-20 8:42 ` He Zhe
2021-04-21 17:17 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e55d2b5-4b6e-7fa2-4851-06cac7defb50@windriver.com \
--to=zhe.he@windriver.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).