From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A07C38A2B for ; Wed, 15 Apr 2020 19:29:27 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21CA820732 for ; Wed, 15 Apr 2020 19:29:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AKIpw8HT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21CA820732 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586978965; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oi1p4YlfG42xc3EmcZQZjYTz4isjREkcyYHxWSJevF0=; b=AKIpw8HTvkRVChEkCJbeKDdvqk/X6tjTgqD0qYljr3/8/GOTDBeQLIuk5zWEeQDeBQX8YT p4k5SFt7H+qbbaypxlXRAWe33Fg1UlehxpT5WIcyEVGOLKuoKn4IL9GE79GkPxH1oEJ+Gr 3/OSo/8Tmxy3ZD4e7sY+pWqie6Ud2Ng= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-Mbs_z8jOPIGUMDv0mLHcMQ-1; Wed, 15 Apr 2020 15:29:24 -0400 X-MC-Unique: Mbs_z8jOPIGUMDv0mLHcMQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF5D2107ACC4; Wed, 15 Apr 2020 19:29:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4D7F118DFE; Wed, 15 Apr 2020 19:29:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 47E0A18089CD; Wed, 15 Apr 2020 19:29:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 03FJRaEl028763 for ; Wed, 15 Apr 2020 15:27:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2926C10013A1; Wed, 15 Apr 2020 19:27:36 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.3.128.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DA471001DC2; Wed, 15 Apr 2020 19:27:26 +0000 (UTC) Date: Wed, 15 Apr 2020 15:27:23 -0400 From: Richard Guy Briggs To: Ondrej Mosnacek Subject: Re: [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer Message-ID: <20200415192723.rrdwtitiu3f2cd67@madcap2.tricolour.ca> References: <20191128153203.GA23803@workstation-kernel-dev> <20191130020742.GF157739@google.com> <20200415153417.svpbimg66vbeuk7u@madcap2.tricolour.ca> <20200415161503.umujm6v4gadmf6qm@madcap2.tricolour.ca> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: linux-audit@redhat.com Cc: Amol Grover , Linux kernel mailing list , Linux-Audit Mailing List , Shuah Khan , Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2020-04-15 18:53, Ondrej Mosnacek wrote: > On Wed, Apr 15, 2020 at 6:15 PM Richard Guy Briggs wrote: > > On 2020-04-15 12:06, Paul Moore wrote: > > > On Wed, Apr 15, 2020 at 11:34 AM Richard Guy Briggs wrote: > > > > On 2019-11-29 21:07, Joel Fernandes wrote: > > > > > On Thu, Nov 28, 2019 at 09:02:03PM +0530, Amol Grover wrote: > > > > > > add __rcu notation to RCU protected global pointer auditd_conn > > > > > > > > > > Again, please use proper punctuation and captilization. This is unacceptable. > > > > > Please put more effort into changelog. > > > > > > > > > > Otherwise the patch diff itself looks good to me, with the above nit > > > > > corrected, you could add my tag to the next revision: > > > > > > > > > > Reviewed-by: Joel Fernandes (Google) > > > > > > > > > > thanks, > > > > > > > > > > - Joel > > > > > > > > > > > > > > > > > Fixes multiple instances of sparse error: > > > > > > error: incompatible types in comparison expression > > > > > > (different address spaces) > > > > > > > > Amol or Joel: Is there a reproducer recipe for this? > > > > > > The commit which was merged has a slightly better description which may help. > > > > I've already seen this. Perhaps I should have replied to this message > > instead to make that evident. What really needed was Amol's original > > message sent to this list, but it was Joel who included this list in his > > reply (all 3 versions). > > > > I'm looking for the specific setup and commands that produced this error. > > You can run make with "C=1", which will run sparse on all files that > are rebuilt during that make run. For example, if I fully build the > kernel and then revert commit > cb5172d96d16df72db8b55146b0ec00bfd97f079, I get: > > $ make [...] C=1 > [...] > CHECK [...]/kernel/audit.c > [...]/kernel/audit.c:218:14: error: incompatible types in comparison > expression (different address spaces): > [...]/kernel/audit.c:218:14: struct auditd_connection [noderef] * > [...]/kernel/audit.c:218:14: struct auditd_connection * > (...and a lot more errors like this + 2 different warnings) > > And when I un-revert it again, I get only the 2 warnings. Perfect, thanks Ondrej. > Ondrej Mosnacek - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit