From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C197C433E2 for ; Wed, 20 May 2020 19:06:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF0DD206B6 for ; Wed, 20 May 2020 19:06:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fZNHjWeV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF0DD206B6 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590001614; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ok8Ry/bNlSZZqrdN1JH0D6AGDnYF1sRic1dFHODA25E=; b=fZNHjWeVLN4GrQqp/KzgXHnuFOG70SNvhsrgnY2b0tf8htQyNbywBYvKaBXIaY+NuHDxOT ZmMv2OPB586QgHUnBqMZQRWZJgNhUgrtnvRXPbj/evJ+nTav6aKzEtiYQSawjjIOMK7rWf P24wxaOtl4ub0n8B7EYCTtt//jH6Bg0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-WlsuGvPkPOiEiI0_s4lSwg-1; Wed, 20 May 2020 15:06:52 -0400 X-MC-Unique: WlsuGvPkPOiEiI0_s4lSwg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7587E107ACCA; Wed, 20 May 2020 19:06:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 244AC7958F; Wed, 20 May 2020 19:06:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CC9C24EDBF; Wed, 20 May 2020 19:06:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04KJ6k56026833 for ; Wed, 20 May 2020 15:06:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5F1966E9E7; Wed, 20 May 2020 19:06:46 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B49162932; Wed, 20 May 2020 19:06:38 +0000 (UTC) Date: Wed, 20 May 2020 15:06:35 -0400 From: Richard Guy Briggs To: Steve Grubb Subject: Re: [PATCH ghak25 v6] audit: add subj creds to NETFILTER_CFG record to cover async unregister Message-ID: <20200520190635.z7iz2ivf53l4bxq6@madcap2.tricolour.ca> References: <20200520165510.4l4q47vq6fyx7hh6@madcap2.tricolour.ca> <17476338.hsbNre52Up@x2> <20200520185922.vnutg5z3hwp7grjm@madcap2.tricolour.ca> MIME-Version: 1.0 In-Reply-To: <20200520185922.vnutg5z3hwp7grjm@madcap2.tricolour.ca> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: linux-audit@redhat.com Cc: fw@strlen.de, LKML , linux-audit@redhat.com, netfilter-devel@vger.kernel.org, twoerner@redhat.com, Eric Paris , tgraf@infradead.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2020-05-20 14:59, Richard Guy Briggs wrote: > On 2020-05-20 14:51, Steve Grubb wrote: > > On Wednesday, May 20, 2020 2:40:45 PM EDT Paul Moore wrote: > > > On Wed, May 20, 2020 at 12:55 PM Richard Guy Briggs wrote: > > > > On 2020-05-20 12:51, Richard Guy Briggs wrote: > > > > > Some table unregister actions seem to be initiated by the kernel to > > > > > garbage collect unused tables that are not initiated by any userspace > > > > > actions. It was found to be necessary to add the subject credentials > > > > > to cover this case to reveal the source of these actions. A sample > > > > > record: > > > > > > > > > > The uid, auid, tty, ses and exe fields have not been included since > > > > > they > > > > > are in the SYSCALL record and contain nothing useful in the non-user > > > > > context. > > > > > > > > > > type=NETFILTER_CFG msg=audit(2020-03-11 21:25:21.491:269) : table=nat > > > > > family=bridge entries=0 op=unregister pid=153 > > > > > subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:2 > > > > > > FWIW, that record looks good. > > > > It's severely broken > > > > cat log.file > > type=NETFILTER_CFG msg=audit(2020-03-11 21:25:21.491:269) : table=nat > > family=bridge entries=0 op=unregister pid=153 > > subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:2 > > > > ausearch -if log.file --format text > > At 19:33:40 12/31/1969 did-unknown > > > > ausearch -if log.file --format csv > > NODE,EVENT,DATE,TIME,SERIAL_NUM,EVENT_KIND,SESSION,SUBJ_PRIME,SUBJ_SEC,SUBJ_KIND,ACTION,RESULT,OBJ_PRIME,OBJ_SEC,OBJ_KIND,HOW > > error normalizing NETFILTER_CFG > > ,NETFILTER_CFG,12/31/1969,19:33:40,0,,,,,,,,,, > > > > This is unusable. This is why the bug was filed in the first place. > > Have you applied this patchset? > https://www.redhat.com/archives/linux-audit/2020-May/msg00072.html > > AUDIT_EVENT_LISTENER is also broken without this first patch. And EVENT_LISTENER also needs this patch: https://github.com/linux-audit/audit-userspace/pull/114/commits/27daa6fca534b30199040d0ad05420a8331ab421 > > -Steve > > > > > > > Signed-off-by: Richard Guy Briggs > > > > > > > > Self-NACK. I forgot to remove cred and tty declarations. > > - RGB - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit