From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A86C433E0 for ; Mon, 25 May 2020 13:21:45 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 058572070A for ; Mon, 25 May 2020 13:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YgNIt01Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 058572070A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590412903; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8p5ke7JIq4X9fFO6+CdoCr/6lQ/AQaJbEGJg8eMvers=; b=YgNIt01QtdkcIxH1HHIcGV59gnfh6EnX6szirZWnF+jfsypyzNgZ5gW3nGeSLo5rkO0Ari vZ6j7rrQwpL2ge2Y/lNg02T9tLBLlvgb0diFKAWKOppniq/FYsvFHxCmZvIJnUUdYpHZlE wYxyM2IVU/t8dGenzPP5MNUyEPzwRTI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-CmXoCJiXNSCYCcU5ZJPfuw-1; Mon, 25 May 2020 09:21:42 -0400 X-MC-Unique: CmXoCJiXNSCYCcU5ZJPfuw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA637107ACF5; Mon, 25 May 2020 13:21:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 486786EDA2; Mon, 25 May 2020 13:21:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B7DB61809543; Mon, 25 May 2020 13:21:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04PDHvnc013204 for ; Mon, 25 May 2020 09:17:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 80D0610013DB; Mon, 25 May 2020 13:17:57 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85F6310013D6; Mon, 25 May 2020 13:17:44 +0000 (UTC) Date: Mon, 25 May 2020 09:17:41 -0400 From: Richard Guy Briggs To: Amol Grover Subject: Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer Message-ID: <20200525131741.s6lgb263fpo5uszk@madcap2.tricolour.ca> References: <20200402055640.6677-1-frextrite@gmail.com> <20200524081117.GA29@workstation-LAP.localdomain> MIME-Version: 1.0 In-Reply-To: <20200524081117.GA29@workstation-LAP.localdomain> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Mon, 25 May 2020 09:21:28 -0400 Cc: Juri Lelli , Peter Zijlstra , David Howells , Joel Fernandes , Vincent Guittot , James Morris , Madhuparna Bhowmik , Ingo Molnar , Mel Gorman , linux-kernel-mentees@lists.linuxfoundation.org, "Paul E . McKenney" , Jann Horn , Steven Rostedt , Shakeel Butt , Thomas Gleixner , Dietmar Eggemann , Ben Segall , linux-kernel@vger.kernel.org, linux-audit@redhat.com, "Eric W . Biederman" , Andrew Morton X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2020-05-24 13:41, Amol Grover wrote: > On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote: > > task_struct::cred (subjective credentials) is *always* used > > task-synchronously, hence, does not require RCU semantics. > > > > task_struct::real_cred (objective credentials) can be used in > > RCU context and its __rcu annotation is retained. > > > > However, task_struct::cred and task_struct::real_cred *may* > > point to the same object, hence, the object pointed to by > > task_struct::cred *may* have RCU delayed freeing. > > > > Suggested-by: Jann Horn > > Co-developed-by: Joel Fernandes (Google) > > Signed-off-by: Joel Fernandes (Google) > > Signed-off-by: Amol Grover > > Hello everyone, > > Could you please go through patches 1/3 and 2/3 and if deemed OK, give > your acks. I sent the original patch in beginning of February (~4 months > back) and resent the patches again in beginning of April due to lack of > traffic. Paul Moore was kind enough to ack twice - the 3/3 and its > resend patch. However these 2 patches still remain. I'd really > appreciate if someone reviewed them. I asked on April 3 which upstream tree you expect this patchset to go through and I did not see a reply. Do you have a specific target or is the large addressee list assuming someone else is taking this set? All we have seen is that it is not intended to go through the audit tree. > Thanks > Amol - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit