From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3053CC433E4 for ; Mon, 3 Aug 2020 12:41:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6CA72054F for ; Mon, 3 Aug 2020 12:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6CA72054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-Ysb5uzKLOv-lYBjPmoQtYA-1; Mon, 03 Aug 2020 08:41:19 -0400 X-MC-Unique: Ysb5uzKLOv-lYBjPmoQtYA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33821800138; Mon, 3 Aug 2020 12:41:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D55D671765; Mon, 3 Aug 2020 12:41:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 11DF81809554; Mon, 3 Aug 2020 12:41:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 073CZGL4005024 for ; Mon, 3 Aug 2020 08:35:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2054A20A053B; Mon, 3 Aug 2020 12:35:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E5342023597 for ; Mon, 3 Aug 2020 12:35:16 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7A7080118C for ; Mon, 3 Aug 2020 12:35:15 +0000 (UTC) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-Gv_zPn0UNdGGEqQRZo4sww-1; Mon, 03 Aug 2020 08:35:12 -0400 X-MC-Unique: Gv_zPn0UNdGGEqQRZo4sww-1 Received: by mail-wm1-f68.google.com with SMTP id d190so14171559wmd.4; Mon, 03 Aug 2020 05:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FTgfPSmSTzWTADmwe07r4VxKyWCszF67jRChwFwa6d0=; b=oqH9+TbOtu8iWiQPkpE84xJ1vfRYX3Ie4KlojgVTg0YI2idCyP0oaebrccyqyGMYNf 01Zf7ZeJj8kY3uxkky5B8z3b+2qr/Hhrbl/Y5cT2KEb/VLiwdh6q6DAJP1St1rpDddX6 67BjuVvfS8IjrrVwuwMKcYqy+tdNF0iVLynQASjU593/ULHnqDz4LTXm/IW0kniOg4K1 PO9jq1XX4L9HFCOaTtJBSJtGuUtpLdYiQBMhMwUYlIyOK14PL4BSEQiC0/Ct8sio1C+T tiRURZXIJMjw7ryqeNncHpXlLc/Udjd0gDijlTE+9t9eJlUCrjE1sW6ysJ0EzxsOrVq/ xzsA== X-Gm-Message-State: AOAM532CTqqG739hjn7CoPDutL4nlTOKhM5OYqMruM+UYyM/0Dc5MYki YqcbfxBMWWurx9UOTbfPrw== X-Google-Smtp-Source: ABdhPJzbe6LZdfAL8EIT/Oh6YY9Xm6ZbUZUyEPTt/DKov8B61cmbhjP3GfR5BPcRyxIrZO4nqxoYSw== X-Received: by 2002:a1c:23c4:: with SMTP id j187mr15931167wmj.58.1596458110852; Mon, 03 Aug 2020 05:35:10 -0700 (PDT) Received: from localhost.lan (host-92-25-238-49.as13285.net. [92.25.238.49]) by smtp.gmail.com with ESMTPSA id u66sm24201133wmu.37.2020.08.03.05.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2020 05:35:10 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Subject: [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid Date: Mon, 3 Aug 2020 13:34:39 +0100 Message-Id: <20200803123439.83400-3-jbi.octave@gmail.com> In-Reply-To: <20200803123439.83400-1-jbi.octave@gmail.com> References: <0/2> <20200803123439.83400-1-jbi.octave@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Mon, 03 Aug 2020 08:41:13 -0400 Cc: Jules Irenge , "moderated list:AUDIT SUBSYSTEM" X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Checkpatch tool reports "ERROR: do not initialise globals/statics to 0" To fix this, audit_sig_sid is uninitialized As this is stored in the .bss section, the compiler can initialize the variable automatically. Signed-off-by: Jules Irenge --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit.c b/kernel/audit.c index afd7827cf6e8..1c74d1d788b6 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; /* The identity of the user shutting down the audit system. */ static kuid_t audit_sig_uid = INVALID_UID; static pid_t audit_sig_pid = -1; -static u32 audit_sig_sid = 0; +static u32 audit_sig_sid; /* Records can be lost in several ways: 0) [suppressed in audit_alloc] -- 2.26.2 -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit