From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F9EC388F9 for ; Wed, 21 Oct 2020 17:55:18 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D76B2225F for ; Wed, 21 Oct 2020 17:55:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AkC/EMM1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D76B2225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603302916; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=39EAkQc0oXLoUX/iCChix6uuCycEXmbnI/Eyg3fvYqg=; b=AkC/EMM1dmUo77uzBvQJyyB5mDEwovEaKg29OWi5eRVJ0e1FJffM2GUBDNq+prKQSlnOBm 6hWzolZO85lsStAHQEW8KhhfxZXskON7I7CEvKu8E+S1Epbw5bBZ/WoUn+PmXwlZ+mjEWc GeVMm5eHHHkfDh8Xn4sC/7hdXPv3rSE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-Ow3lOeAuO3-us9PJnOcRwg-1; Wed, 21 Oct 2020 13:55:14 -0400 X-MC-Unique: Ow3lOeAuO3-us9PJnOcRwg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FF991006C94; Wed, 21 Oct 2020 17:55:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4C4F5C1C7; Wed, 21 Oct 2020 17:55:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ECD3C181A71F; Wed, 21 Oct 2020 17:55:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09LHrKMR014490 for ; Wed, 21 Oct 2020 13:53:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 564135D9F1; Wed, 21 Oct 2020 17:53:20 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E934B5D9EF; Wed, 21 Oct 2020 17:53:06 +0000 (UTC) Date: Wed, 21 Oct 2020 13:53:03 -0400 From: Richard Guy Briggs To: Steve Grubb Subject: Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls Message-ID: <20201021175303.GH2882171@madcap2.tricolour.ca> References: <20201002195231.GH2882171@madcap2.tricolour.ca> <20201021163926.GA3929765@madcap2.tricolour.ca> <2174083.ElGaqSPkdT@x2> MIME-Version: 1.0 In-Reply-To: <2174083.ElGaqSPkdT@x2> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: linux-audit@redhat.com Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , dhowells@redhat.com, linux-audit@redhat.com, netfilter-devel@vger.kernel.org, ebiederm@xmission.com, simo@redhat.com, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Paris , mpatel@redhat.com, Serge Hallyn X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2020-10-21 12:49, Steve Grubb wrote: > On Wednesday, October 21, 2020 12:39:26 PM EDT Richard Guy Briggs wrote: > > > I think I have a way to generate a signal to multiple targets in one > > > syscall... The added challenge is to also give those targets different > > > audit container identifiers. > > > > Here is an exmple I was able to generate after updating the testsuite > > script to include a signalling example of a nested audit container > > identifier: > > > > ---- > > type=PROCTITLE msg=audit(2020-10-21 10:31:16.655:6731) : > > proctitle=/usr/bin/perl -w containerid/test type=CONTAINER_ID > > msg=audit(2020-10-21 10:31:16.655:6731) : > > contid=7129731255799087104^3333941723245477888 type=OBJ_PID > > msg=audit(2020-10-21 10:31:16.655:6731) : opid=115583 oauid=root ouid=root > > oses=1 obj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 > > ocomm=perl type=CONTAINER_ID msg=audit(2020-10-21 10:31:16.655:6731) : > > contid=3333941723245477888 type=OBJ_PID msg=audit(2020-10-21 > > 10:31:16.655:6731) : opid=115580 oauid=root ouid=root oses=1 > > obj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 ocomm=perl > > type=CONTAINER_ID msg=audit(2020-10-21 10:31:16.655:6731) : > > contid=8098399240850112512^3333941723245477888 type=OBJ_PID > > msg=audit(2020-10-21 10:31:16.655:6731) : opid=115582 oauid=root ouid=root > > oses=1 obj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 > > ocomm=perl type=SYSCALL msg=audit(2020-10-21 10:31:16.655:6731) : > > arch=x86_64 syscall=kill success=yes exit=0 a0=0xfffe3c84 a1=SIGTERM > > a2=0x4d524554 a3=0x0 items=0 ppid=115564 pid=115567 auid=root uid=root > > gid=root euid=root suid=root fsuid=root egid=root sgid=root fsgid=root > > tty=ttyS0 ses=1 comm=perl exe=/usr/bin/perl > > subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 > > key=testsuite-1603290671-AcLtUulY ---- > > > > There are three CONTAINER_ID records which need some way of associating > > with OBJ_PID records. An additional CONTAINER_ID record would be present > > if the killing process itself had an audit container identifier. I think > > the most obvious way to connect them is with a pid= field in the > > CONTAINER_ID record. > > pid is the process sending the signal, opid is the process receiving the > signal. I think you mean opid? If the process sending the signal (it has a pid= field) has an audit container identifier, it will generate a CONTAINER_ID record. Each process being signalled (each has an opid= field) that has an audit container identifier will also generate a CONTAINER_ID record. The former will be much more common. Which do we use in the CONTAINER_ID record? Having swinging fields, pid vs opid does not seem like a reasonable solution. Do we go back to "ref=pid=..." vs "ref=opid=..."? > -Steve - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit