From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA31C433C1 for ; Mon, 22 Mar 2021 17:58:45 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D33C61874 for ; Mon, 22 Mar 2021 17:58:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D33C61874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616435924; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=91lCJ8dUA3w8IzqL4oEnWZLGQD25uHbGcC0ZF9j6yUI=; b=PHIlrUeaAuwD8srXuGnoU6TdPO1e07UEtL3RIzF3iMGSaSV7gkAWsAp3mdhcAkEX8PpKZs 97e7qqpIpploUn2gtplRcuuXz0qhVlByJjjWQgkgf+ycPICjXNxGGZrq/97V6CQs6JyuAR d5uKpMUoXa1oaaa2a+c70mKpf2UH98c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-x4e7ztTYNQKTVgMh0j4xSw-1; Mon, 22 Mar 2021 13:58:42 -0400 X-MC-Unique: x4e7ztTYNQKTVgMh0j4xSw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D6F9A0CA1; Mon, 22 Mar 2021 17:58:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AE9260BE5; Mon, 22 Mar 2021 17:58:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 858A11809C83; Mon, 22 Mar 2021 17:58:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MHwUtH022076 for ; Mon, 22 Mar 2021 13:58:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id EE8FD10023AB; Mon, 22 Mar 2021 17:58:30 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32BC11002388; Mon, 22 Mar 2021 17:58:24 +0000 (UTC) Date: Mon, 22 Mar 2021 13:58:21 -0400 From: Richard Guy Briggs To: Arnd Bergmann Subject: Re: [PATCH] audit: avoid -Wempty-body warning Message-ID: <20210322175821.GO3141668@madcap2.tricolour.ca> References: <20210322114536.3517661-1-arnd@kernel.org> <20210322143344.GN3141668@madcap2.tricolour.ca> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: linux-audit@redhat.com Cc: Jules Irenge , linux-audit@redhat.com, Linux Kernel Mailing List X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2021-03-22 17:28, Arnd Bergmann wrote: > On Mon, Mar 22, 2021 at 3:33 PM Richard Guy Briggs wrote: > > > Change the macros to use the usual "do { } while (0)" instead, and change a > > > few more that were (void)0, for consistency. > > > > So what about audit_put_watch() and audit_get_watch() which are set to > > {}? (And all of include/linux/audit.h that uses the latter...) Does > > this only matter if they are the only action called in an if or loop? > > I missed those, thanks for pointing it out. I sent a v2 patch now. Ok, cool, that looks more consistent. Can you answer my question about include/linux/audit.h and exactly what conditions require "do { } while (0)" over "{ }"? > Arnd - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit