From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D59F8C433B4 for ; Thu, 1 Apr 2021 16:43:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2736136B for ; Thu, 1 Apr 2021 16:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2736136B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617295410; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QnWsZCpJ4YeVBUUTiOhowvkKkFRY1ey2k7sezqMe2Cg=; b=X9cSed+sF9GCClMr1ADMq0yoEoNU+/f4EAhFkZtUEhuKTJhnHebDxOF22Fbov/MG99SJBN K5OVfJYAx0qWrSuqhD/veX8vqLzr0bPDOWkJJwjNK2dsIo+0qaxY6y0lCYzgx4fbQiN7UO H3ZuUkoPPVsStNusH6bdLwTy94cEX2A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-cDig0qXtNzKSWV_Im1bz_g-1; Thu, 01 Apr 2021 12:43:25 -0400 X-MC-Unique: cDig0qXtNzKSWV_Im1bz_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7809800D53; Thu, 1 Apr 2021 16:43:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 914051B49D; Thu, 1 Apr 2021 16:43:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3BB4E4BB7C; Thu, 1 Apr 2021 16:43:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131GhDci012433 for ; Thu, 1 Apr 2021 12:43:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 06ACD1B528; Thu, 1 Apr 2021 16:43:13 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1178F1B49D; Thu, 1 Apr 2021 16:43:06 +0000 (UTC) Date: Thu, 1 Apr 2021 12:43:01 -0400 From: Richard Guy Briggs To: Paul Moore Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid Message-ID: <20210401164301.GC3141668@madcap2.tricolour.ca> References: <14139c54992a4b50448fbbf07ebbfed743e09f3a.1616095045.git.rgb@redhat.com> <20210401154827.2f801300@coco.lan> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: linux-audit@redhat.com Cc: Jonathan Corbet , Mauro Carvalho Chehab , Greg KH , LKML , Linux-Audit Mailing List , Eric Paris X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2021-04-01 09:57, Paul Moore wrote: > On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab > wrote: > > Em Thu, 18 Mar 2021 15:19:10 -0400 > > Richard Guy Briggs escreveu: > > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > > > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle > > > loginuid through proc") > > > > > > Signed-off-by: Richard Guy Briggs > > > --- > > > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid > > > > > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid > > > new file mode 100644 > > > index 000000000000..e7c100b9ab18 > > > --- /dev/null > > > +++ b/Documentation/ABI/stable/procfs-audit_loginuid > > > @@ -0,0 +1,15 @@ > > > +What: Audit Login UID > > > +Date: 2005-02-01 > > > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc") > > > +Contact: linux-audit@redhat.com > > > +Format: %u > > > > The ABI definition doesn't include a "Format:" symbol. See: > > > > Documentation/ABI/README > > > > For the valid ones. > > > > This change causes a warning at the ABI parser: > > > > > > $ ./scripts/get_abi.pl validate > > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5: > > tag 'contact' is invalid. Line > > Format: %u > > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21: > > tag 'contact' is invalid. Line > > Format: %u > > > > You should either drop it or add it to the parser and to the README > > file, if the ABI maintainers are ok with such new field. > > Thanks Mauro, I didn't realize there were tools that parsed these files. > > Richard, please post a patch that drops the 'Format:' line from the > newly added audit files as soon as possible so I can merge it into > audit/next. Ok. I'll roll it into the description so we don't lose that information. > paul moore - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit