From: Richard Guy Briggs <rgb@redhat.com>
To: Baokun Li <libaokun1@huawei.com>
Cc: yangjihong1@huawei.com, kernel-janitors@vger.kernel.org,
yuehaibing@huawei.com, linux-kernel@vger.kernel.org,
Eric Paris <eparis@redhat.com>, Hulk Robot <hulkci@huawei.com>,
linux-audit@redhat.com, weiyongjun1@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH -next] audit: Use list_move instead of list_del/list_add
Date: Tue, 8 Jun 2021 11:02:03 -0400 [thread overview]
Message-ID: <20210608150203.GB2268484@madcap2.tricolour.ca> (raw)
In-Reply-To: <20210608031150.2821712-1-libaokun1@huawei.com>
On 2021-06-08 11:11, Baokun Li wrote:
> Using list_move() instead of list_del() + list_add().
This should be slightly more efficient since there is no need to poison
the pointers.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Acked-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> kernel/audit_tree.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index 6c91902f4f45..b2be4e978ba3 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -689,8 +689,7 @@ void audit_trim_trees(void)
>
> tree = container_of(cursor.next, struct audit_tree, list);
> get_tree(tree);
> - list_del(&cursor);
> - list_add(&cursor, &tree->list);
> + list_move(&cursor, &tree->list);
> mutex_unlock(&audit_filter_mutex);
>
> err = kern_path(tree->pathname, 0, &path);
> @@ -899,8 +898,7 @@ int audit_tag_tree(char *old, char *new)
>
> tree = container_of(cursor.next, struct audit_tree, list);
> get_tree(tree);
> - list_del(&cursor);
> - list_add(&cursor, &tree->list);
> + list_move(&cursor, &tree->list);
> mutex_unlock(&audit_filter_mutex);
>
> err = kern_path(tree->pathname, 0, &path2);
> @@ -925,8 +923,7 @@ int audit_tag_tree(char *old, char *new)
> mutex_lock(&audit_filter_mutex);
> spin_lock(&hash_lock);
> if (!tree->goner) {
> - list_del(&tree->list);
> - list_add(&tree->list, &tree_list);
> + list_move(&tree->list, &tree_list);
> }
> spin_unlock(&hash_lock);
> put_tree(tree);
> @@ -937,8 +934,7 @@ int audit_tag_tree(char *old, char *new)
>
> tree = container_of(barrier.prev, struct audit_tree, list);
> get_tree(tree);
> - list_del(&tree->list);
> - list_add(&tree->list, &barrier);
> + list_move(&tree->list, &barrier);
> mutex_unlock(&audit_filter_mutex);
>
> if (!failed) {
>
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://listman.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-06-08 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 3:11 [PATCH -next] audit: Use list_move instead of list_del/list_add Baokun Li
2021-06-08 15:02 ` Richard Guy Briggs [this message]
2021-06-09 2:19 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608150203.GB2268484@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=eparis@redhat.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).