From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: john.johansen@canonical.com, kbuild-all@lists.01.org,
linux-audit@redhat.com
Subject: Re: [PATCH v27 21/25] audit: add support for non-syscall auxiliary records
Date: Wed, 16 Jun 2021 22:54:50 +0800 [thread overview]
Message-ID: <202106162222.NKRvIRiX-lkp@intel.com> (raw)
In-Reply-To: <20210611000435.36398-22-casey@schaufler-ca.com>
[-- Attachment #1: Type: text/plain, Size: 6664 bytes --]
Hi Casey,
I love your patch! Yet something to improve:
[auto build test ERROR on nf/master]
[also build test ERROR on linus/master v5.13-rc6]
[cannot apply to security/next-testing pcmoore-audit/next nf-next/master next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: m68k-randconfig-r021-20210615 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c6c28a65377a02c1aa05846e32c56cb015da9904
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
git checkout c6c28a65377a02c1aa05846e32c56cb015da9904
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/fsnotify.h:16,
from fs/configfs/dir.c:14:
>> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' token
557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
--
In file included from include/linux/fsnotify.h:16,
from fs/cachefiles/namei.c:12:
>> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' token
557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
fs/cachefiles/namei.c: In function 'cachefiles_walk_to_object':
fs/cachefiles/namei.c:499:16: warning: variable 'start' set but not used [-Wunused-but-set-variable]
499 | unsigned long start;
| ^~~~~
fs/cachefiles/namei.c: In function 'cachefiles_get_directory':
fs/cachefiles/namei.c:768:16: warning: variable 'start' set but not used [-Wunused-but-set-variable]
768 | unsigned long start;
| ^~~~~
fs/cachefiles/namei.c: In function 'cachefiles_check_active':
fs/cachefiles/namei.c:879:16: warning: variable 'start' set but not used [-Wunused-but-set-variable]
879 | unsigned long start;
| ^~~~~
--
In file included from fs/pipe.c:23:
>> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' token
557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
fs/pipe.c:741:15: warning: no previous prototype for 'account_pipe_buffers' [-Wmissing-prototypes]
741 | unsigned long account_pipe_buffers(struct user_struct *user,
| ^~~~~~~~~~~~~~~~~~~~
fs/pipe.c:747:6: warning: no previous prototype for 'too_many_pipe_buffers_soft' [-Wmissing-prototypes]
747 | bool too_many_pipe_buffers_soft(unsigned long user_bufs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:754:6: warning: no previous prototype for 'too_many_pipe_buffers_hard' [-Wmissing-prototypes]
754 | bool too_many_pipe_buffers_hard(unsigned long user_bufs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:761:6: warning: no previous prototype for 'pipe_is_unprivileged_user' [-Wmissing-prototypes]
761 | bool pipe_is_unprivileged_user(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:1231:5: warning: no previous prototype for 'pipe_resize_ring' [-Wmissing-prototypes]
1231 | int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots)
| ^~~~~~~~~~~~~~~~
vim +557 include/linux/audit.h
553
554 extern int audit_n_rules;
555 extern int audit_signals;
556 #else /* CONFIG_AUDITSYSCALL */
> 557 +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
558 {
559 return NULL;
560 }
561 static inline void audit_free_context(struct audit_context *context)
562 { }
563 static inline int audit_alloc(struct task_struct *task)
564 {
565 return 0;
566 }
567 static inline void audit_free(struct task_struct *task)
568 { }
569 static inline void audit_syscall_entry(int major, unsigned long a0,
570 unsigned long a1, unsigned long a2,
571 unsigned long a3)
572 { }
573 static inline void audit_syscall_exit(void *pt_regs)
574 { }
575 static inline bool audit_dummy_context(void)
576 {
577 return true;
578 }
579 static inline void audit_set_context(struct task_struct *task, struct audit_context *ctx)
580 { }
581 static inline struct audit_context *audit_context(void)
582 {
583 return NULL;
584 }
585 static inline struct filename *audit_reusename(const __user char *name)
586 {
587 return NULL;
588 }
589 static inline void audit_getname(struct filename *name)
590 { }
591 static inline void audit_inode(struct filename *name,
592 const struct dentry *dentry,
593 unsigned int aflags)
594 { }
595 static inline void audit_file(struct file *file)
596 {
597 }
598 static inline void audit_inode_parent_hidden(struct filename *name,
599 const struct dentry *dentry)
600 { }
601 static inline void audit_inode_child(struct inode *parent,
602 const struct dentry *dentry,
603 const unsigned char type)
604 { }
605 static inline void audit_core_dumps(long signr)
606 { }
607 static inline void audit_seccomp(unsigned long syscall, long signr, int code)
608 { }
609 static inline void audit_seccomp_actions_logged(const char *names,
610 const char *old_names, int res)
611 { }
612 static inline void audit_ipc_obj(struct kern_ipc_perm *ipcp)
613 { }
614 static inline void audit_ipc_set_perm(unsigned long qbytes, uid_t uid,
615 gid_t gid, umode_t mode)
616 { }
617 static inline void audit_bprm(struct linux_binprm *bprm)
618 { }
619 static inline int audit_socketcall(int nargs, unsigned long *args)
620 {
621 return 0;
622 }
623
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22441 bytes --]
[-- Attachment #3: Type: text/plain, Size: 106 bytes --]
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-06-16 15:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210611000435.36398-1-casey.ref@schaufler-ca.com>
2021-06-11 0:04 ` [PATCH v27 00/25] LSM: Module stacking for AppArmor Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 01/25] LSM: Infrastructure management of the sock security Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 02/25] LSM: Add the lsmblob data structure Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 03/25] LSM: provide lsm name and id slot mappings Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 04/25] IMA: avoid label collisions with stacked LSMs Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 05/25] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 06/25] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 07/25] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 08/25] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 09/25] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 10/25] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 11/25] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 12/25] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 13/25] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 14/25] LSM: Specify which LSM to display Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 15/25] LSM: Ensure the correct LSM context releaser Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 16/25] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 17/25] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 18/25] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 19/25] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 20/25] LSM: Verify LSM display sanity in binder Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 21/25] audit: add support for non-syscall auxiliary records Casey Schaufler
2021-06-16 14:54 ` kernel test robot [this message]
2021-06-16 15:05 ` kernel test robot
2021-06-11 0:04 ` [PATCH v27 22/25] Audit: Add record for multiple process LSM attributes Casey Schaufler
2021-06-16 10:33 ` kernel test robot
2021-06-16 17:55 ` kernel test robot
2021-06-11 0:04 ` [PATCH v27 23/25] Audit: Add record for multiple object " Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 24/25] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 25/25] AppArmor: Remove the exclusive flag Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106162222.NKRvIRiX-lkp@intel.com \
--to=lkp@intel.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).