From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E895FC433FE for ; Wed, 15 Sep 2021 12:29:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BF656108F for ; Wed, 15 Sep 2021 12:29:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BF656108F Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631708971; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tDs/+uPRGgDxku1QMosTD5+iTlG4AC626xwPNq/FRG4=; b=V9kReBhep8NXwAnHZoTOjE2dvGenBMFDgcT1lg6HC9zBz/2W3DobreFRTexAjISDG+gXjq 4jMSyM9/UxBZt7gK7RfO9Hedwz5IR9aRGh0vxXgAQzrrhZMHE5WA1asLehDdpc5iSiVXgk SdhYlFCLCPwaOT9H/tM9wtC6KXJbKz4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-_HEoufO5OuiEI_GXOPPJmA-1; Wed, 15 Sep 2021 08:29:30 -0400 X-MC-Unique: _HEoufO5OuiEI_GXOPPJmA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1E2DA40C0; Wed, 15 Sep 2021 12:29:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AE3460C81; Wed, 15 Sep 2021 12:29:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 94EFB180142F; Wed, 15 Sep 2021 12:29:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18FCTKAI010305 for ; Wed, 15 Sep 2021 08:29:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id C7B0F196F8; Wed, 15 Sep 2021 12:29:20 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.3.128.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA64D19736; Wed, 15 Sep 2021 12:29:10 +0000 (UTC) Date: Wed, 15 Sep 2021 08:29:08 -0400 From: Richard Guy Briggs To: Paul Moore Subject: Re: [RFC PATCH v2 0/9] Add LSM access controls and auditing to io_uring Message-ID: <20210915122907.GM490529@madcap2.tricolour.ca> References: <20210827133559.GG490529@madcap2.tricolour.ca> <20210828150356.GH490529@madcap2.tricolour.ca> <20210910005858.GL490529@madcap2.tricolour.ca> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: linux-audit@redhat.com Cc: Jens Axboe , selinux@vger.kernel.org, Pavel Begunkov , linux-security-module@vger.kernel.org, linux-audit@redhat.com, Kumar Kartikeya Dwivedi , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2021-09-13 22:49, Paul Moore wrote: > On Mon, Sep 13, 2021 at 9:50 PM Paul Moore wrote: > > On Mon, Sep 13, 2021 at 3:23 PM Paul Moore wrote: > > > On Thu, Sep 9, 2021 at 8:59 PM Richard Guy Briggs wrote: > > > > On 2021-09-01 15:21, Paul Moore wrote: > > > > > On Sun, Aug 29, 2021 at 11:18 AM Paul Moore wrote: > > > > > > On Sat, Aug 28, 2021 at 11:04 AM Richard Guy Briggs wrote: > > > > > > > I did set a syscall filter for > > > > > > > -a exit,always -F arch=b64 -S io_uring_enter,io_uring_setup,io_uring_register -F key=iouringsyscall > > > > > > > and that yielded some records with a couple of orphans that surprised me > > > > > > > a bit. > > > > > > > > > > > > Without looking too closely at the log you sent, you can expect URING > > > > > > records without an associated SYSCALL record when the uring op is > > > > > > being processed in the io-wq or sqpoll context. In the io-wq case the > > > > > > processing is happening after the thread finished the syscall but > > > > > > before the execution context returns to userspace and in the case of > > > > > > sqpoll the processing is handled by a separate kernel thread with no > > > > > > association to a process thread. > > > > > > > > > > I spent some time this morning/afternoon playing with the io_uring > > > > > audit filtering capability and with your audit userspace > > > > > ghau-iouring-filtering.v1.0 branch it appears to work correctly. Yes, > > > > > the userspace tooling isn't quite 100% yet (e.g. `auditctl -l` doesn't > > > > > map the io_uring ops correctly), but I know you mentioned you have a > > > > > number of fixes/improvements still as a work-in-progress there so I'm > > > > > not too concerned. The important part is that the kernel pieces look > > > > > to be working correctly. > > > > > > > > Ok, I have squashed and pushed the audit userspace support for iouring: > > > > https://github.com/rgbriggs/audit-userspace/commit/e8bd8d2ea8adcaa758024cb9b8fa93895ae35eea > > > > https://github.com/linux-audit/audit-userspace/compare/master...rgbriggs:ghak-iouring-filtering.v2.1 > > > > There are test rpms for f35 here: > > > > http://people.redhat.com/~rbriggs/ghak-iouring/git-e8bd8d2-fc35/ > > > > > > > > userspace v2 changelog: > > > > - check for watch before adding perm > > > > - update manpage to include filesystem filter > > > > - update support for the uring filter list: doc, -U op, op names > > > > - add support for the AUDIT_URINGOP record type > > > > - add uringop support to ausearch > > > > - add uringop support to aureport > > > > - lots of bug fixes > > > > > > > > "auditctl -a uring,always -S ..." will now throw an error and require > > > > "-U" instead. > > > > > > Thanks Richard. > > > > > > FYI, I rebased the io_uring/LSM/audit patchset on top of v5.15-rc1 > > > today and tested both with your v1.0 and with your v2.1 branch and the > > > various combinations seemed to work just fine (of course the v2.1 > > > userspace branch was more polished, less warts, etc.). I'm going to > > > go over the patch set one more time to make sure everything is still > > > looking good, write up an updated cover letter, and post a v3 revision > > > later tonight with the hope of merging it into -next later this week. > > > > Best laid plans of mice and men ... > > > > It turns out the LSM hook macros are full of warnings-now-errors that > > should likely be resolved before sending anything LSM related to > > Linus. I'll post v3 once I fix this, which may not be until tomorrow. > > > > (To be clear, the warnings/errors aren't new to this patchset, I'm > > likely just the first person to notice them.) > > Actually, scratch that ... I'm thinking that might just be an oddity > of the Intel 0day test robot building for the xtensa arch. I'll post > the v3 patchset tonight. I was in the middle of reviewing the v2 patchset to add my acks when I forgot to add the comment that you still haven't convinced me that ses= isn't needed or relevant if we are including auid=. > paul moore - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit