From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6A8C433E0 for ; Tue, 16 Jun 2020 15:29:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A85C2208D5 for ; Tue, 16 Jun 2020 15:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XgfRGOJV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A85C2208D5 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592321380; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qbIctReG/zEk/G4KXWduLuQRZGfZFPJNwKVDp1cQQKA=; b=XgfRGOJVoApVDT3mgYnoIaXknDjX94MCm2FS5OSVAUk1gRblo+1mqB4ZoLlDlx4/S2cuEH daOm535eJvqI3LHM4O2xZGN/jqLvqUoDklfq6h5hA4C/e1RuURGsYY0tyPY9oPd5M3ggqC aPLdTLCX38AD5fzVLur4CepAxqhtkxw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-g-0QzPfiMmSvH0aHimURlg-1; Tue, 16 Jun 2020 11:29:37 -0400 X-MC-Unique: g-0QzPfiMmSvH0aHimURlg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E891107AFB2; Tue, 16 Jun 2020 15:29:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A71EB5C1BD; Tue, 16 Jun 2020 15:29:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F2961809547; Tue, 16 Jun 2020 15:29:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GFTPwf028804 for ; Tue, 16 Jun 2020 11:29:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1B4EA1001901; Tue, 16 Jun 2020 15:29:25 +0000 (UTC) Received: from x2.localnet (ovpn-113-82.phx2.redhat.com [10.3.113.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5559110013D6; Tue, 16 Jun 2020 15:29:24 +0000 (UTC) From: Steve Grubb To: Paul Moore Subject: Re: [PATCH 1/2] integrity: Add errno field in audit message Date: Tue, 16 Jun 2020 11:29:22 -0400 Message-ID: <6643272.rC52FQZPYE@x2> Organization: Red Hat In-Reply-To: References: <20200611000400.3771-1-nramas@linux.microsoft.com> <8800031.dr63W5FlUW@x2> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: linux-audit@redhat.com Cc: rgb@redhat.com, linux-kernel@vger.kernel.org, Mimi Zohar , Lakshmi Ramasubramanian , linux-audit@redhat.com, linux-integrity@vger.kernel.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Monday, June 15, 2020 6:58:13 PM EDT Paul Moore wrote: > On Mon, Jun 15, 2020 at 6:23 PM Steve Grubb wrote: > > On Friday, June 12, 2020 3:50:14 PM EDT Lakshmi Ramasubramanian wrote: > > > On 6/12/20 12:25 PM, Mimi Zohar wrote: > > > > The idea is a good idea, but you're assuming that "result" is always > > > > errno. That was probably true originally, but isn't now. For > > > > example, ima_appraise_measurement() calls xattr_verify(), which > > > > compares the security.ima hash with the calculated file hash. On > > > > failure, it returns the result of memcmp(). Each and every code path > > > > will need to be checked. > > > > > > Good catch Mimi. > > > > > > Instead of "errno" should we just use "result" and log the value given > > > in the result parameter? > > > > That would likely collide with another field of the same name which is > > the > > operation's results. If it really is errno, the name is fine. It's > > generic > > enough that it can be reused on other events if that mattered. > > Steve, what is the historical reason why we have both "res" and > "result" for indicating a boolean success/fail? I'm just curious how > we ended up this way, and who may still be using "result". I think its pam and some other user space things did this. But because of mixed machines in datacenters supporting multiple versions of OS, we have to leave result alone. It has to be 0,1 or success/fail. We cannot use it for errno. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit