Linux-audit Archive on lore.kernel.org
 help / color / Atom feed
From: Joe Perches <joe@perches.com>
To: Jules Irenge <jbi.octave@gmail.com>, linux-kernel@vger.kernel.org
Cc: "moderated list:AUDIT SUBSYSTEM" <linux-audit@redhat.com>
Subject: Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
Date: Sat, 01 Aug 2020 11:55:43 -0700
Message-ID: <91c6c45f0d8ec0d031c216711cd8d7f6e9aad7ad.camel@perches.com> (raw)
In-Reply-To: <20200801184603.310769-3-jbi.octave@gmail.com>

On Sat, 2020-08-01 at 19:46 +0100, Jules Irenge wrote:
> Checkpatch tool reports an error at variable audit_sig_sid declaration
[]
> diff --git a/kernel/audit.c b/kernel/audit.c
[]
> @@ -125,7 +125,7 @@ static u32	audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
>  /* The identity of the user shutting down the audit system. */
>  kuid_t		audit_sig_uid = INVALID_UID;
>  pid_t		audit_sig_pid = -1;
> -u32		audit_sig_sid = 0;
> +u32		audit_sig_sid;

All of these are unused outside of audit.c and might as
well be static and removed from the .h file.


--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/4>
     [not found] ` <20200801184603.310769-1-jbi.octave@gmail.com>
2020-08-01 18:46   ` Jules Irenge
2020-08-01 18:55     ` Joe Perches [this message]
2020-08-01 20:26       ` Paul Moore
2020-08-02 14:32       ` Jules Irenge
2020-08-01 18:46   ` [PATCH 3/4] audit: uninitialize static variables Jules Irenge
2020-08-01 20:21     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91c6c45f0d8ec0d031c216711cd8d7f6e9aad7ad.camel@perches.com \
    --to=joe@perches.com \
    --cc=jbi.octave@gmail.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-audit Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-audit/0 linux-audit/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-audit linux-audit/ https://lore.kernel.org/linux-audit \
		linux-audit@redhat.com
	public-inbox-index linux-audit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.redhat.linux-audit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git