From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B7AC433EF for ; Wed, 15 Sep 2021 17:47:15 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEC161164 for ; Wed, 15 Sep 2021 17:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8DEC161164 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631728033; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nDNz0R7rMFCxx8OjtCm1UASD2lN1uLRO1Ir0mfGvGtc=; b=ExtF0mFQgaPfu4II5dIM2OF7UgtVfiTkx5N62HxL87WngKCQyxIifZq6PuuVmUSeYVM04Y 2NMzQXnGhMwqaI3qwfBOl+CMw8xeMG+Dkfi/GCQPAKWoyUWA1GjbBOvRjWDgYI3W2qvYlI 7GGekDh+xHj7mV6+n7Xeicft9UeVZ+M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-Tv61l1RePVq9oPzq7I1uQw-1; Wed, 15 Sep 2021 13:47:12 -0400 X-MC-Unique: Tv61l1RePVq9oPzq7I1uQw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC762101796C; Wed, 15 Sep 2021 17:47:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 930E717F72; Wed, 15 Sep 2021 17:47:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9510D4EA30; Wed, 15 Sep 2021 17:47:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18FHiudo010165 for ; Wed, 15 Sep 2021 13:44:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id D99C419736; Wed, 15 Sep 2021 17:44:56 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0E88196F1; Wed, 15 Sep 2021 17:44:52 +0000 (UTC) From: Steve Grubb To: Enzo Matsumiya Subject: Re: [PATCH] auditd: fix missing space with enriched log format Date: Wed, 15 Sep 2021 13:44:52 -0400 Message-ID: <9990430.nUPlyArG6x@x2> Organization: Red Hat In-Reply-To: <20210915145228.2wz3s7ok7eggdujj@cyberdelia> References: <20210915015548.8515-1-ematsumiya@suse.de> <11826656.O9o76ZdvQC@x2> <20210915145228.2wz3s7ok7eggdujj@cyberdelia> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wednesday, September 15, 2021 10:52:28 AM EDT Enzo Matsumiya wrote: > On 09/14, Steve Grubb wrote: > >On Tuesday, September 14, 2021 9:55:48 PM EDT Enzo Matsumiya wrote: > >> When audit.log is opened with cat or less, for example, with log format > >> = ENRICHED, there's no space between data and the enriched part, only > > > >> AUDIT_INTERP_SEPARATOR (0x1d): > >This is by design. > > I understand that, and the patch doesn't break it. > > >> type=USER_CMD msg=audit(1631669179.082:2403): ... res=success'UID="enzo" > >> AUID="unset" ^ (0x1d) > >> > >> sep_done should be checked if it's 1 as well, so a space is added before > >> the first enriched field. > > > >Why? > > Some people still rely on opening audit.log with tools that are not aware > of the log format. There is another log format, RAW, which should be suitable for the old tools. Also, I don't understand what problems that causes. You haven't exactly explained what the problem is and why this is needed. The ENRICHED format has been documented for over 5 years. Plenty of time for tools to become aware. > As far as I could test, the change is only cosmetic, as I expected. I did a > basic test with ausearch and it was ok. > > Please clarify if you expect anything else to be affected by this > change. Without more context, I am reluctant to change a documented standard that has existed for over 5 years. https://github.com/linux-audit/audit-documentation/wiki/SPEC-Audit-Event-Enrichment -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit