From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D862C433E0 for ; Thu, 4 Mar 2021 14:24:04 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B92564F02 for ; Thu, 4 Mar 2021 14:24:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B92564F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-CjYh_W6ePJ-GadfJMbuONA-1; Thu, 04 Mar 2021 09:24:00 -0500 X-MC-Unique: CjYh_W6ePJ-GadfJMbuONA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A87E71005D4C; Thu, 4 Mar 2021 14:23:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AF0C19CAB; Thu, 4 Mar 2021 14:23:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7D8374A714; Thu, 4 Mar 2021 14:23:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 124A4Peh013060 for ; Thu, 4 Mar 2021 05:04:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2150D5B4498; Thu, 4 Mar 2021 10:04:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B8ED5B4491 for ; Thu, 4 Mar 2021 10:04:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AAD038551FD for ; Thu, 4 Mar 2021 10:04:22 +0000 (UTC) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-12zjHa1sPtGERiNmSmLUzw-1; Thu, 04 Mar 2021 05:04:20 -0500 X-MC-Unique: 12zjHa1sPtGERiNmSmLUzw-1 Received: by mail-lf1-f41.google.com with SMTP id b1so31437186lfb.7 for ; Thu, 04 Mar 2021 02:04:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5HmF/e/2OcwQXp/j0kIXsyRnmJkQXEhil+DWEn4X3ys=; b=J1k1jjbFPvAs3bzusZ8E1jPjA+iwOH1+TGF5K5PDF4QHn3NwmK86IdeeTbMEuwJv32 snVrOcUXdxQRvDcxCsx/MG/ZL6RSe+RRYfiLvroUovgzEFyG2VMBu+TjOiFs5IkpvnfN O08QRsXJasSTC2EjRApRE+tFm/1MPYCwb9vDvpcXVp6/kekppGTdhcZRodq78LvzvqrN u9nsXXMZHhR0WA0jP1fLim66efE3QfUVRgWoHViw+jrawwsh3TYitZbVGV5+KH5jhKTw 9saILN4PvguhACNpmcMh9LxVc6SB3nAzG6Lqb+F6eDP1x9wNSzBddLaQ+wvA5vBUnDrg wFhA== X-Gm-Message-State: AOAM533FMoe5fw6vnQXJcsCC/7+s7vcPTd+8ZWL2/JYs7L470vPwrJfC /Jfmx2DFxRWwP9Qxdh8c1oGteYoYvytGvWSDs4NKXQ== X-Google-Smtp-Source: ABdhPJyl1u4pWz3yNDHUKgDfDvH1MVqlmeYrM203Ucy1U0m2qSyuIg1rqpKYE0SyAb+kXOd4HvFOAWDMUs8erTwzhUg= X-Received: by 2002:ac2:48b1:: with SMTP id u17mr1930986lfg.627.1614852258548; Thu, 04 Mar 2021 02:04:18 -0800 (PST) MIME-Version: 1.0 References: <161377712068.87807.12246856567527156637.stgit@sifl> <161377734508.87807.8537642254664217815.stgit@sifl> In-Reply-To: From: Jeffrey Vander Stoep Date: Thu, 4 Mar 2021 11:04:07 +0100 Message-ID: Subject: Re: [RFC PATCH 1/4] lsm: separate security_task_getsecid() into subjective and objective variants To: Paul Moore X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Thu, 04 Mar 2021 09:23:50 -0500 Cc: John Johansen , SElinux list , James Morris , LSM List , linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Feb 20, 2021 at 3:45 PM Paul Moore wrote: > > On Fri, Feb 19, 2021 at 9:57 PM James Morris wrote: > > On Fri, 19 Feb 2021, Paul Moore wrote: > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > > index c119736ca56ac..39d501261108d 100644 > > > --- a/drivers/android/binder.c > > > +++ b/drivers/android/binder.c > > > @@ -2700,7 +2700,7 @@ static void binder_transaction(struct binder_proc *proc, > > > u32 secid; > > > size_t added_size; > > > > > > - security_task_getsecid(proc->tsk, &secid); > > > + security_task_getsecid_subj(proc->tsk, &secid); > > > ret = security_secid_to_secctx(secid, &secctx, &secctx_sz); > > > if (ret) { > > > return_error = BR_FAILED_REPLY; > > > > Can someone from the Android project confirm this is correct for binder? This looks correct to me. > > Yes, please take a look Android folks. As I mentioned previously, > review of the binder changes is one area where I think some extra > review is needed; I'm just not confident enough in my understanding of > binder. > > -- > paul moore > www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit