Linux-audit Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Richard Guy Briggs <rgb@redhat.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-Audit Mailing List <linux-audit@redhat.com>,
	Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid
Date: Thu, 1 Apr 2021 09:57:55 -0400
Message-ID: <CAHC9VhQ6d7_gX2dWSK9Wnk1p+w+1yOPb=Yf8fTCeMbhGru0iUg@mail.gmail.com> (raw)
In-Reply-To: <20210401154827.2f801300@coco.lan>

On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> Em Thu, 18 Mar 2021 15:19:10 -0400
> Richard Guy Briggs <rgb@redhat.com> escreveu:
> > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> > loginuid through proc")
> >
> > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > ---
> >  Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> >
> > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
> > new file mode 100644
> > index 000000000000..e7c100b9ab18
> > --- /dev/null
> > +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> > @@ -0,0 +1,15 @@
> > +What:                Audit Login UID
> > +Date:                2005-02-01
> > +KernelVersion:       2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
> > +Contact:     linux-audit@redhat.com
> > +Format:              %u
>
> The ABI definition doesn't include a "Format:" symbol. See:
>
>         Documentation/ABI/README
>
> For the valid ones.
>
> This change causes a warning at the ABI parser:
>
>
>         $ ./scripts/get_abi.pl validate
>         Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
>                 tag 'contact' is invalid. Line
>                         Format:         %u
>         Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
>                 tag 'contact' is invalid. Line
>                         Format:         %u
>
> You should either drop it or add it to the parser and to the README
> file, if the ABI maintainers are ok with such new field.

Thanks Mauro, I didn't realize there were tools that parsed these files.

Richard, please post a patch that drops the 'Format:' line from the
newly added audit files as soon as possible so I can merge it into
audit/next.

-- 
paul moore
www.paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 19:19 [PATCH v3 0/2] audit: add documentation for /proc/PID/stable interfaces Richard Guy Briggs
2021-03-18 19:19 ` [PATCH v3 1/2] audit: document /proc/PID/loginuid Richard Guy Briggs
2021-03-18 20:59   ` Paul Moore
2021-04-01 13:48   ` Mauro Carvalho Chehab
2021-04-01 13:57     ` Paul Moore [this message]
2021-04-01 16:43       ` Richard Guy Briggs
2021-03-18 19:19 ` [PATCH v3 2/2] audit: document /proc/PID/sessionid Richard Guy Briggs
2021-03-18 21:00   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhQ6d7_gX2dWSK9Wnk1p+w+1yOPb=Yf8fTCeMbhGru0iUg@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=corbet@lwn.net \
    --cc=eparis@parisplace.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-audit Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-audit/0 linux-audit/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-audit linux-audit/ https://lore.kernel.org/linux-audit \
		linux-audit@redhat.com
	public-inbox-index linux-audit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.redhat.linux-audit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git