From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E75EC433ED for ; Thu, 1 Apr 2021 13:58:23 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 924DC610CF for ; Thu, 1 Apr 2021 13:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 924DC610CF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-D0g4bLLHP4CnPfGmZgHWmw-1; Thu, 01 Apr 2021 09:58:20 -0400 X-MC-Unique: D0g4bLLHP4CnPfGmZgHWmw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D9366B9DA; Thu, 1 Apr 2021 13:58:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66C636F130; Thu, 1 Apr 2021 13:58:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A1A44A700; Thu, 1 Apr 2021 13:58:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131DwD8n025331 for ; Thu, 1 Apr 2021 09:58:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3D54E2157F24; Thu, 1 Apr 2021 13:58:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37C822157F23 for ; Thu, 1 Apr 2021 13:58:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F6D8185A7B5 for ; Thu, 1 Apr 2021 13:58:10 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-zviij4fyOqiCrsIucPgQdQ-1; Thu, 01 Apr 2021 09:58:07 -0400 X-MC-Unique: zviij4fyOqiCrsIucPgQdQ-1 Received: by mail-ed1-f42.google.com with SMTP id z1so2057061edb.8 for ; Thu, 01 Apr 2021 06:58:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sGU7ZT7+8QwMgBJMRItGXfNyZM26bXJF2/PUv7FUxvY=; b=S26zNOTTyPCNxQayThGYaSynV0zRajJktBaZaMSia/yMz7sdDpgLwYVkIKXyX+qKS2 fFkiMBHqS0MTpgcnWK8FuXIX6SadiJ+TSHCT86Jyfish6VHQMjnMpvavxZI4jaq8qktO UuM3X45HGZoJtrcik63o+Xv9I4SBtNfvsgTDWa+rvcysx18JVae8AhCTPJVZJ891z1ae CX6KhFND/0s0qzhUoG+vO6//z9/ITtAQ5vA2fs0G2gXaHJRw0eyjcuHeLx3FH63YYL8O HThTXKETQYsiYYtlzMtQ+jMZPSdRdy4DVlAASx+bPGEtw4+xNMJW2TKpsXsqnrO4EGo2 8M0A== X-Gm-Message-State: AOAM533f2SyIdNQvAAAX7VDdn8qAt3M4zUGXUm+AL4mjn3X40B2bGyAu kh8ZwtE1Ga+GD8DjFLc4fGi2Agfy2rjHECr6xVp3mfdi/A== X-Google-Smtp-Source: ABdhPJxw4nDiadCckjeSPqlBGtvIBsGhzqc6ScATkGiOfkdigUx5G+2vuz33V5RwX3qH4QaIJiehDxQTSjCW14KNGZg= X-Received: by 2002:a05:6402:105a:: with SMTP id e26mr10077031edu.164.1617285486539; Thu, 01 Apr 2021 06:58:06 -0700 (PDT) MIME-Version: 1.0 References: <14139c54992a4b50448fbbf07ebbfed743e09f3a.1616095045.git.rgb@redhat.com> <20210401154827.2f801300@coco.lan> In-Reply-To: <20210401154827.2f801300@coco.lan> From: Paul Moore Date: Thu, 1 Apr 2021 09:57:55 -0400 Message-ID: Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid To: Mauro Carvalho Chehab X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com Cc: Jonathan Corbet , Richard Guy Briggs , Greg KH , LKML , Linux-Audit Mailing List , Eric Paris X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab wrote: > Em Thu, 18 Mar 2021 15:19:10 -0400 > Richard Guy Briggs escreveu: > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle > > loginuid through proc") > > > > Signed-off-by: Richard Guy Briggs > > --- > > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid > > > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid > > new file mode 100644 > > index 000000000000..e7c100b9ab18 > > --- /dev/null > > +++ b/Documentation/ABI/stable/procfs-audit_loginuid > > @@ -0,0 +1,15 @@ > > +What: Audit Login UID > > +Date: 2005-02-01 > > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc") > > +Contact: linux-audit@redhat.com > > +Format: %u > > The ABI definition doesn't include a "Format:" symbol. See: > > Documentation/ABI/README > > For the valid ones. > > This change causes a warning at the ABI parser: > > > $ ./scripts/get_abi.pl validate > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5: > tag 'contact' is invalid. Line > Format: %u > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21: > tag 'contact' is invalid. Line > Format: %u > > You should either drop it or add it to the parser and to the README > file, if the ABI maintainers are ok with such new field. Thanks Mauro, I didn't realize there were tools that parsed these files. Richard, please post a patch that drops the 'Format:' line from the newly added audit files as soon as possible so I can merge it into audit/next. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit