From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65B5C433E1 for ; Thu, 6 Aug 2020 18:36:42 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0BE7206B5 for ; Thu, 6 Aug 2020 18:36:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0BE7206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-sptkuxYtO_6G3WKZmfmw9A-1; Thu, 06 Aug 2020 14:36:39 -0400 X-MC-Unique: sptkuxYtO_6G3WKZmfmw9A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E48848017FB; Thu, 6 Aug 2020 18:36:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC5DF19C71; Thu, 6 Aug 2020 18:36:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96FF51809554; Thu, 6 Aug 2020 18:36:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 076IZVSj007425 for ; Thu, 6 Aug 2020 14:35:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 235282166B27; Thu, 6 Aug 2020 18:35:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EC7B2156A4F for ; Thu, 6 Aug 2020 18:35:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3F2D8007D1 for ; Thu, 6 Aug 2020 18:35:27 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-wDYSjBTaPyKEgYwClAQpug-1; Thu, 06 Aug 2020 14:35:25 -0400 X-MC-Unique: wDYSjBTaPyKEgYwClAQpug-1 Received: by mail-ed1-f66.google.com with SMTP id l23so22149237edv.11 for ; Thu, 06 Aug 2020 11:35:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xuh5L///1+6tqkx4SRS1RotcWxk6pfAkKpYSeAk+r38=; b=lXOUB60hG1g/qn8e9NadFEstnmE86njXH8XMrK/2yOCsVABV1kKh1njNyRFXcg5bs9 v6iZu4skiIqRRyTXUgdtm6ghF2aQC51M6oYEBD1HdqFZnLOpJtwdyaUvP/w4bWcMsszl YwfQBLjQHamsWycWCR0/Yop9WrZOLVLHoeve1i/zr/lxi71C4zgR+PP9jsIj6arZnn05 k7OORVVkakvxzWPfiAVy0mk1k4HbnHATkuoBM73FYNXHSZXw7YU1FPjl545vFo9L9Mtx afw+/3JxuO+yO6IxZUB5H3QfeIT/lUzLDJZmYbwadUP7MvvaPf5xJFZYPHj3LiGjj8fI 2Nkg== X-Gm-Message-State: AOAM530EGEV97N9gGjAg0QQG9hup88AmvZeycNxtbWkdjKia0uuxrru2 WKwAQLKQpZOuUrPSJcGPsB1b1rFZRWsIJlTgM68a X-Google-Smtp-Source: ABdhPJzobp3XHFhPQHypcdgsf1CVg1Hjp7fpOVXPXt5WPfkFAmsIZUO5MG4ZWuct7JxXuKpRwr1fkzSlTGifEgIyyd8= X-Received: by 2002:a50:93c5:: with SMTP id o63mr5213126eda.31.1596738924215; Thu, 06 Aug 2020 11:35:24 -0700 (PDT) MIME-Version: 1.0 References: <20200803123439.83400-1-jbi.octave@gmail.com> <20200803123439.83400-3-jbi.octave@gmail.com> In-Reply-To: <20200803123439.83400-3-jbi.octave@gmail.com> From: Paul Moore Date: Thu, 6 Aug 2020 14:35:13 -0400 Message-ID: Subject: Re: [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid To: Jules Irenge X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com Cc: "moderated list:AUDIT SUBSYSTEM" , linux-kernel@vger.kernel.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge wrote: > > Checkpatch tool reports > > "ERROR: do not initialise globals/statics to 0" > > To fix this, audit_sig_sid is uninitialized > As this is stored in the .bss section, > the compiler can initialize the variable automatically. > > Signed-off-by: Jules Irenge > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Similar to patch 1/2, this will need to wait until after the merge window closes. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit