From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2ADC433DB for ; Fri, 12 Mar 2021 19:16:53 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B71664F84 for ; Fri, 12 Mar 2021 19:16:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B71664F84 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-2Q_vw_sTNEWcVJ5aMvuIPA-1; Fri, 12 Mar 2021 14:16:49 -0500 X-MC-Unique: 2Q_vw_sTNEWcVJ5aMvuIPA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF37F1846098; Fri, 12 Mar 2021 19:16:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EBBE60918; Fri, 12 Mar 2021 19:16:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0C0641800232; Fri, 12 Mar 2021 19:16:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12CJFkTm008385 for ; Fri, 12 Mar 2021 14:15:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id 47804106A41; Fri, 12 Mar 2021 19:15:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41613106A47 for ; Fri, 12 Mar 2021 19:15:43 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E4D21021E2D for ; Fri, 12 Mar 2021 19:15:43 +0000 (UTC) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-j4Mj3H0pOlenkG0yWJvjXQ-1; Fri, 12 Mar 2021 14:15:41 -0500 X-MC-Unique: j4Mj3H0pOlenkG0yWJvjXQ-1 Received: by mail-ej1-f48.google.com with SMTP id e19so55493819ejt.3 for ; Fri, 12 Mar 2021 11:15:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xJfM+I5HqJFFYJ65C4XP9E9lkasVMia7svQJuRMmO9U=; b=lZBjZgr6i5PpDRZ95Brkl35PS8nbBQfhsZXekl/FZvC33rKs65wKz99TJPLdGpNMEs pb31YUQZQomcLv7sggk+I0VDD5Gswze6xkKW07RAPSmGjyGkBkSnySSfORC8xdgitPgc vkgAbLzgj/dE6qPy8dQg2yG01Rmb/ng6cwGRMPNRVrztoPcxslbxxWriJjP2DucGNy8M c4R9PD6QZsw/MLeduoMX4rrXc1m7x2GC7ZE4eqA9hRKkLDkcjHPoD8x51SNcF1kvrUar kkcJqQHbGVII8u+nRCM2uqcxQKIa4PdCMM4U4veN0JVToKA4WfZbGmkIXaEr/K9SrqJs kKVg== X-Gm-Message-State: AOAM530fWBm0zPU30EhMqKeFxujaRU/3L5dqLkOBorWZ6CDjAC/uIdOP kSQpnV5c/hZXkgB0xb/8Qyp6NO9rxmrkd7xUOwe7 X-Google-Smtp-Source: ABdhPJyW1i4bRVgK1CIQV5uJdUKrirYYDE6X9ulg01wuX+VWr+puT2u8BurlKxyMpi9dwpgdM3hqlqPDJsMsaOXvnaA= X-Received: by 2002:a17:906:e116:: with SMTP id gj22mr10028144ejb.398.1615576539704; Fri, 12 Mar 2021 11:15:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Fri, 12 Mar 2021 14:15:28 -0500 Message-ID: Subject: Re: [PATCH 1/2] audit: document /proc/PID/loginuid To: Richard Guy Briggs X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: linux-audit@redhat.com Cc: Eric Paris , Linux-Audit Mailing List , LKML X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs wrote: > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle > loginuid through proc") > > Signed-off-by: Richard Guy Briggs > --- > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid After ~15 years, it might be time ;) > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid > new file mode 100664 > index 000000000000..fae63bef2970 > --- /dev/null > +++ b/Documentation/ABI/stable/procfs-audit_loginuid > @@ -0,0 +1,15 @@ > +What: Audit Login UID > +Date: 2005-02-01 > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc") > +Contact: linux-audit@redhat.com > +Format: u32 I haven't applied the patch, but I'm going to assume that the "u32" lines up correctly with the rest of the entries, right? > +Users: auditd, libaudit, audit-testsuite, login I think these entries are a bit too specific as I expect the kernel to outlive most userspace libraries and applications. I would suggest "audit and login applications" or something similar. > +Description: > + The /proc/$pid/loginuid pseudofile is written to set and I'm really in no position to critique someone's English grammar, but if we're talking about changes I might add a comma after "set", "... is written to set, and read to get ...". > + read to get the audit login UID of process $pid. If it is > + unset, permissions are not needed to set it. The accessor must > + have CAP_AUDIT_CONTROL in the initial user namespace to write > + it if it has been set. It cannot be written again if > + AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled. It cannot be > + unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit