From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF6FC433E1 for ; Tue, 18 Aug 2020 00:38:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0D312078D for ; Tue, 18 Aug 2020 00:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0D312078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-K3xL_aDlP5CFF83oE8Hqjg-1; Mon, 17 Aug 2020 20:38:44 -0400 X-MC-Unique: K3xL_aDlP5CFF83oE8Hqjg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F1C210066FB; Tue, 18 Aug 2020 00:38:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8637A10098FB; Tue, 18 Aug 2020 00:38:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B743E59CCD; Tue, 18 Aug 2020 00:38:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 07I0cXEX004343 for ; Mon, 17 Aug 2020 20:38:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 381CC2166BDB; Tue, 18 Aug 2020 00:38:33 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 340C12166BCC for ; Tue, 18 Aug 2020 00:38:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 383CC800BED for ; Tue, 18 Aug 2020 00:38:30 +0000 (UTC) Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-lbr8rztXNJyorUTTznTIEA-1; Mon, 17 Aug 2020 20:38:25 -0400 X-MC-Unique: lbr8rztXNJyorUTTznTIEA-1 Received: by mail-ej1-f68.google.com with SMTP id f24so20003559ejx.6 for ; Mon, 17 Aug 2020 17:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=llLDdslF9VJQ+TYHo8ll+MktUpA631YAS7CkJsS+nq8=; b=o0CNwDE3BkNashWnHtPmanVhgs5lyn0bIODixgTL0ErRlgBE5GUb4/0afp5qoGnhk3 c6qhQM4wDrYok9YwU89wAXgkmGIhaNMdOIin54pvmgYJz2wEfqe7OhZ3nrWaN60EWmXM pZIy0kb2fNBLz9VAdNwL0hFFutB4AstZTeQllQrfj2DTlznsVyMm3vuQIskfWuB5OeqC /HgcQcMm1CqJQjJywDzYvIorb8+rXxlcsDlzzsB2Jp69coOD3+YLitsWt71YcZLJvZEz gGW8dF0lVJCKzh5f0Zun7ftauHzGAsi2HEoaqxqC6A2qBBuToI4lPX/EhuWv2vzpk4sg 2wig== X-Gm-Message-State: AOAM533tnjUC3yCc5anXPKHOgyflhy4UHE+E61ibciOpDb+Pbd2n9GXm jXyHrczIIjgLVsU18V/yio3Ng3pHsG4FRBCpcayo X-Google-Smtp-Source: ABdhPJxD/WHhrRHYPJ7Z6bI5LpRYeokjFbmCu3YWL+lFCVHWHiC3mpb/U0Y3UJuJEW5i0MrlwMBf6u3gwyMLyrvfIvs= X-Received: by 2002:a17:906:990c:: with SMTP id zl12mr17327397ejb.488.1597711104381; Mon, 17 Aug 2020 17:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20200803123439.83400-1-jbi.octave@gmail.com> <20200803123439.83400-2-jbi.octave@gmail.com> In-Reply-To: From: Paul Moore Date: Mon, 17 Aug 2020 20:38:13 -0400 Message-ID: Subject: Re: [RESEND PATCH 1/2] audit: change unnecessary globals into statics To: Jules Irenge X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com Cc: "moderated list:AUDIT SUBSYSTEM" , linux-kernel@vger.kernel.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 6, 2020 at 2:33 PM Paul Moore wrote: > > On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge wrote: > > > > Variables sig_pid, audit_sig_uid and audit_sig_sid > > are only used in the audit.c file across the kernel > > Hence it appears no reason for declaring them as globals > > This patch removes their global declarations from the .h file > > and change them into static in the .c file. > > > > Signed-off-by: Jules Irenge > > --- > > kernel/audit.c | 6 +++--- > > kernel/audit.h | 4 ---- > > 2 files changed, 3 insertions(+), 7 deletions(-) > > Thanks Jules, this looks reasonable although I'm not going to merge > them into audit/next until after the merge window closes. I'll send > another reply once this has been merged. ... and I just merged this into audit/next, thanks Jules. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit