Linux-audit Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] audit: drop /proc/PID/loginuid documentation Format field
@ 2021-04-01 19:10 Richard Guy Briggs
  2021-04-01 22:33 ` Paul Moore
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Guy Briggs @ 2021-04-01 19:10 UTC (permalink / raw)
  To: Linux-Audit Mailing List, LKML
  Cc: Richard Guy Briggs, Eric Paris, Mauro Carvalho Chehab

Drop the "Format:" field from the /proc/PID/loginuid documentation and
integrate the information into the Description field since it is not
recognized by the "./scripts/get_abi.pl validate" command which causes a
warning.  Documentation/ABI/README describes the valid fields.

Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
 .../ABI/stable/procfs-audit_loginuid          | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
index 9d55a3ff4b34..cda405178391 100644
--- a/Documentation/ABI/stable/procfs-audit_loginuid
+++ b/Documentation/ABI/stable/procfs-audit_loginuid
@@ -2,26 +2,26 @@ What:		Audit Login UID
 Date:		2005-02-01
 KernelVersion:	2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
 Contact:	linux-audit@redhat.com
-Format:		%u
 Users:		audit and login applications
 Description:
 		The /proc/$pid/loginuid pseudofile is written to set and
-		read to get the audit login UID of process $pid.  If it is
-		unset, permissions are not needed to set it.  The accessor must
-		have CAP_AUDIT_CONTROL in the initial user namespace to write
-		it if it has been set.  It cannot be written again if
-		AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled.  It cannot be
-		unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled.
-
+		read to get the audit login UID of process $pid as a
+		decimal unsigned int (%u, u32).  If it is unset,
+		permissions are not needed to set it.  The accessor must
+		have CAP_AUDIT_CONTROL in the initial user namespace to
+		write it if it has been set.  It cannot be written again
+		if AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled.  It
+		cannot be unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is
+		enabled.
 
 What:		Audit Login Session ID
 Date:		2008-03-13
 KernelVersion:	2.6.25-rc7 1e0bd7550ea9 ("[PATCH] export sessionid alongside the loginuid in procfs")
 Contact:	linux-audit@redhat.com
-Format:		%u
 Users:		audit and login applications
 Description:
 		The /proc/$pid/sessionid pseudofile is read to get the
-		audit login session ID of process $pid.  It is set
-		automatically, serially assigned with each new login.
+		audit login session ID of process $pid as a decimal
+		unsigned int (%u, u32).  It is set automatically,
+		serially assigned with each new login.
 
-- 
2.27.0

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] audit: drop /proc/PID/loginuid documentation Format field
  2021-04-01 19:10 [PATCH] audit: drop /proc/PID/loginuid documentation Format field Richard Guy Briggs
@ 2021-04-01 22:33 ` Paul Moore
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2021-04-01 22:33 UTC (permalink / raw)
  To: Richard Guy Briggs
  Cc: Mauro Carvalho Chehab, Eric Paris, Linux-Audit Mailing List, LKML

On Thu, Apr 1, 2021 at 3:11 PM Richard Guy Briggs <rgb@redhat.com> wrote:
>
> Drop the "Format:" field from the /proc/PID/loginuid documentation and
> integrate the information into the Description field since it is not
> recognized by the "./scripts/get_abi.pl validate" command which causes a
> warning.  Documentation/ABI/README describes the valid fields.
>
> Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  .../ABI/stable/procfs-audit_loginuid          | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Merged into audit/next, thanks.

-- 
paul moore
www.paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 19:10 [PATCH] audit: drop /proc/PID/loginuid documentation Format field Richard Guy Briggs
2021-04-01 22:33 ` Paul Moore

Linux-audit Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-audit/0 linux-audit/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-audit linux-audit/ https://lore.kernel.org/linux-audit \
		linux-audit@redhat.com
	public-inbox-index linux-audit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.redhat.linux-audit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git