From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH] audit: mark expected switch fall-through Date: Tue, 12 Feb 2019 20:19:44 -0500 Message-ID: References: <20190212204600.GA24049@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190212204600.GA24049@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" Cc: Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Kees Cook List-Id: linux-audit@redhat.com On Tue, Feb 12, 2019 at 3:46 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > kernel/auditfilter.c: In function =E2=80=98audit_krule_to_data=E2=80=99: > kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wi= mplicit-fallthrough=3D] > if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) { > ^ > kernel/auditfilter.c:674:3: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3D3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva > --- > kernel/auditfilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged into audit/next, thanks. --=20 paul moore www.paul-moore.com