From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH ghak90 V8 13/16] audit: track container nesting Date: Wed, 5 Feb 2020 17:57:55 -0500 Message-ID: References: <3665686.i1MIc9PeWa@x2> <35934535.C1y6eIYgqz@x2> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <35934535.C1y6eIYgqz@x2> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Grubb Cc: Richard Guy Briggs , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-Audit Mailing List , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, omosnace-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, simo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Eric Paris , Serge Hallyn , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, Dan Walsh , mpatel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-audit@redhat.com On Tue, Feb 4, 2020 at 1:12 PM Steve Grubb wrote: > On Tuesday, February 4, 2020 10:52:36 AM EST Paul Moore wrote: > > On Tue, Feb 4, 2020 at 10:47 AM Steve Grubb wrote: > > > On Tuesday, February 4, 2020 8:19:44 AM EST Richard Guy Briggs wrote: > > > > > The established pattern is that we print -1 when its unset and "?" > > > > > when > > > > > its totalling missing. So, how could this be invalid? It should be > > > > > set > > > > > or not. That is unless its totally missing just like when we do not > > > > > run > > > > > with selinux enabled and a context just doesn't exist. > > > > > > > > Ok, so in this case it is clearly unset, so should be -1, which will be > > > > a > > > > 20-digit number when represented as an unsigned long long int. > > > > > > > > Thank you for that clarification Steve. > > > > > > It is literally a -1. ( 2 characters) > > > > Well, not as Richard has currently written the code, it is a "%llu". > > This was why I asked the question I did; if we want the "-1" here we > > probably want to special case that as I don't think we want to display > > audit container IDs as signed numbers in general. > > OK, then go with the long number, we'll fix it in the interpretation. I guess > we do the same thing for auid. As I said above, I'm okay with a special case handling for unset/"-1" in this case. -- paul moore www.paul-moore.com