From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2BAC433F5 for ; Sun, 3 Oct 2021 23:22:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C54A61100 for ; Sun, 3 Oct 2021 23:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C54A61100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-8vt2YK2uMAi06CmIQcqQsQ-1; Sun, 03 Oct 2021 19:22:08 -0400 X-MC-Unique: 8vt2YK2uMAi06CmIQcqQsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D23F1084681; Sun, 3 Oct 2021 23:22:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8FD85D740; Sun, 3 Oct 2021 23:22:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F0E24E58E; Sun, 3 Oct 2021 23:21:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 193NLqF7009895 for ; Sun, 3 Oct 2021 19:21:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id D4C14568D1; Sun, 3 Oct 2021 23:21:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD9E1568D3 for ; Sun, 3 Oct 2021 23:21:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0033F10AF7C1 for ; Sun, 3 Oct 2021 23:21:50 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563--kXMlmT7PpecfKdnu1oe7Q-1; Sun, 03 Oct 2021 19:21:48 -0400 X-MC-Unique: -kXMlmT7PpecfKdnu1oe7Q-1 Received: by mail-ed1-f42.google.com with SMTP id bd28so57607739edb.9 for ; Sun, 03 Oct 2021 16:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=00CWwoZAxo7pjwh+pplnVtSurQHexBVNjPBA+nUVxhY=; b=kYSyFXLeB9rZYp7s/G69bFcHbt6pZWM1NvcuOOizXkRMUbkFZclKrNFsuubYWritEk NoPij3x4TX64GCcECAMsLd6PAO7W32xAZt3Gc7/nnoH7xynTYC0Jz0qwnTA1LHhtrpfS gOtoAeqfkVbPJ8RBwNpZJD8YFGz6/nu2yXQyiQYhEVYyDcZ84mSsP/opHOYqEvVsilpo jkR0oFeDaEU5xsISUWDUXjmrSE2sCT/Ypwvk55sTVdDObvzpFzVj4BhyrN7EffX4PdHd YeHckLq6euwNj3myeMLQbMGmj/bizLi6O9yP8KeyMCHP5sy6JHZfUYVEq1OON1umHUM4 143g== X-Gm-Message-State: AOAM532pNFSJV18q2wW570u1nyfM3rrFzoScvzBVJpGw3pdDqVNmwC9l MyHxOduXE8fCwv6m3gLXrc8Ok43cnu24inAeOjf/qHjek1Bl X-Google-Smtp-Source: ABdhPJy2A51NHoGUA9o/S4OIDYyN7Vt7ClEyMA6xUA8P281KlL9VN2fL4d1Mlchthgl/47ZCI/oT9/ZCzntauHDfjV8= X-Received: by 2002:a17:906:919:: with SMTP id i25mr13203650ejd.171.1633303306597; Sun, 03 Oct 2021 16:21:46 -0700 (PDT) MIME-Version: 1.0 References: <20210824205724.GB490529@madcap2.tricolour.ca> <20210910005858.GL490529@madcap2.tricolour.ca> <4721749.31r3eYUQgx@x2> In-Reply-To: <4721749.31r3eYUQgx@x2> From: Paul Moore Date: Sun, 3 Oct 2021 19:21:38 -0400 Message-ID: Subject: Re: [RFC PATCH v2 0/9] Add LSM access controls and auditing to io_uring To: Steve Grubb , Richard Guy Briggs X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Oct 2, 2021 at 9:16 AM Steve Grubb wrote: > Hello, > > Since this is a chat to discuss merging the user space piece, I trimmed the > recipients down to the audit community. Good idea. > On Thursday, September 9, 2021 8:58:58 PM EDT Richard Guy Briggs wrote: > > > I spent some time this morning/afternoon playing with the io_uring > > > audit filtering capability and with your audit userspace > > > ghau-iouring-filtering.v1.0 branch it appears to work correctly. Yes, > > > the userspace tooling isn't quite 100% yet (e.g. `auditctl -l` doesn't > > > map the io_uring ops correctly), but I know you mentioned you have a > > > number of fixes/improvements still as a work-in-progress there so I'm > > > not too concerned. The important part is that the kernel pieces look > > > to be working correctly. > > > > Ok, I have squashed and pushed the audit userspace support for iouring: > > > > https://github.com/rgbriggs/audit-userspace/commit/e8bd8d2ea8adcaa758024cb > > 9b8fa93895ae35eea > > https://github.com/linux-audit/audit-userspace/compare/master...rgbriggs:g > > hak-iouring-filtering.v2.1 There are test rpms for f35 here: > > http://people.redhat.com/~rbriggs/ghak-iouring/git-e8bd8d2-fc35/ > > > > userspace v2 changelog: > > - check for watch before adding perm > > - update manpage to include filesystem filter > > - update support for the uring filter list: doc, -U op, op names > > - add support for the AUDIT_URINGOP record type > > - add uringop support to ausearch > > - add uringop support to aureport > > - lots of bug fixes > > > > "auditctl -a uring,always -S ..." will now throw an error and require > > "-U" instead. > > OK, now that the bug fix release is out of the way, let's start merging this > into user space. I think we should start with the code that let's auditd > write the record correctly and then the auditctl piece that inserts the rule > into the kernel. Those should be easy to merge. > > I see one section of code that mirrors all of the operations in ioring.h. I > thought that Paul only wanted to audit some of the operations and not all of > them. Did that change? Are we really going to allow auditing reads on ioring? Only certain io_uring operations are audited, you can see the patch here in the selinux/next tree (look for the io_op_defs struct changes and the "audit_skip" field): https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git/commit/?h=next&id=5bd2182d58e9d9c6279b7a8a2f9b41add0e7f9cb -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit