From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC8A5C4338F for ; Tue, 24 Aug 2021 14:48:15 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D5406127B for ; Tue, 24 Aug 2021 14:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5D5406127B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-N4-fmlq_Mc6R2x-SYkYyow-1; Tue, 24 Aug 2021 10:48:13 -0400 X-MC-Unique: N4-fmlq_Mc6R2x-SYkYyow-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CAD48799EC; Tue, 24 Aug 2021 14:48:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CAAD1F6; Tue, 24 Aug 2021 14:48:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3497B4BB7C; Tue, 24 Aug 2021 14:48:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17OEm62S006810 for ; Tue, 24 Aug 2021 10:48:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id B209B2039DB1; Tue, 24 Aug 2021 14:48:06 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADE7E2039DAD for ; Tue, 24 Aug 2021 14:48:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BADBB80B72F for ; Tue, 24 Aug 2021 14:48:03 +0000 (UTC) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-cJfrrIatPja3rQFoc9z_NQ-1; Tue, 24 Aug 2021 10:48:01 -0400 X-MC-Unique: cJfrrIatPja3rQFoc9z_NQ-1 Received: by mail-ej1-f44.google.com with SMTP id a25so18212867ejv.6 for ; Tue, 24 Aug 2021 07:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YnPUVfUgYHSOqP3q+uA993Pwu7eBA1Aa+0lCfjRXQXc=; b=tUsi+dxYoF3OPHH33B0fTg6SG8aUaCOy/LbT0+cw1t1K3qArF9MuywQ7fj377uTJnJ vGTMa/mU5S4Hzbkk/mbEeNLZAgX3uG8uM56KcWQKWPTst05z4DKtM3uzFz4jomyFhSt1 OgCifKHYM1/4vaHyk3UwbDz9rFS9G+jINlmLJqmBknxOYIgXnynKtJGb/iOi+60PQVk6 HspTqKwajWJDgtMc44PBqVAcI2LoKjX+h9eaVEvqVIz4PuDec3K3zdgG+1kpKIxW1DPq xyOlY0yKQp/1SSowf5lHYLkfRyrpLv6RtZAEIBzc8mM8segFM5UflW8aB8kpgBY1yTwM dCzg== X-Gm-Message-State: AOAM5313Mx3K31caPyxBSbYXC55bYOxwa2viVOJtiUxUUccAwojTS8Nb xSXIwgejGaPE3CSVjTJqqSNPTVJg+NLIi0oH2cL9 X-Google-Smtp-Source: ABdhPJxxDRaVp902LyjVDf+++7H1g3lySJYE9BZ6QHXVbA1LPabtUCfvWTFh7RVPbzZMkPo7LlN4qe4Aq61ZtmMifrk= X-Received: by 2002:a17:906:2755:: with SMTP id a21mr40640335ejd.488.1629816480152; Tue, 24 Aug 2021 07:48:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Tue, 24 Aug 2021 10:47:49 -0400 Message-ID: Subject: Re: [PATCH v2 RESEND] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC To: Christophe Leroy X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com Cc: Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Eric Paris , linux-audit@redhat.com, Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Aug 24, 2021 at 9:36 AM Christophe Leroy wrote: > > Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal > targets") added generic support for AUDIT but that didn't include > support for bi-arch like powerpc. > > Commit 4b58841149dc ("audit: Add generic compat syscall support") > added generic support for bi-arch. > > Convert powerpc to that bi-arch generic audit support. > > Cc: Paul Moore > Cc: Eric Paris > Signed-off-by: Christophe Leroy > --- > Resending v2 with Audit people in Cc > > v2: > - Missing 'git add' for arch/powerpc/include/asm/unistd32.h > - Finalised commit description > --- > arch/powerpc/Kconfig | 5 +- > arch/powerpc/include/asm/unistd32.h | 7 +++ > arch/powerpc/kernel/Makefile | 3 -- > arch/powerpc/kernel/audit.c | 84 ----------------------------- > arch/powerpc/kernel/compat_audit.c | 44 --------------- > 5 files changed, 8 insertions(+), 135 deletions(-) > create mode 100644 arch/powerpc/include/asm/unistd32.h > delete mode 100644 arch/powerpc/kernel/audit.c > delete mode 100644 arch/powerpc/kernel/compat_audit.c Can you explain, in detail please, the testing you have done to verify this patch? -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit