From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320A3C433DF for ; Mon, 29 Jun 2020 23:24:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B115420780 for ; Mon, 29 Jun 2020 23:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B115420780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-YdmWj3NiMmagiU1htN0-3g-1; Mon, 29 Jun 2020 19:24:10 -0400 X-MC-Unique: YdmWj3NiMmagiU1htN0-3g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E6C51005513; Mon, 29 Jun 2020 23:24:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B1427BEC1; Mon, 29 Jun 2020 23:24:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9ED6687897; Mon, 29 Jun 2020 23:24:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05TNO1Zr017216 for ; Mon, 29 Jun 2020 19:24:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id 093E52157F25; Mon, 29 Jun 2020 23:24:01 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 052902166BA3 for ; Mon, 29 Jun 2020 23:23:59 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09EE5924901 for ; Mon, 29 Jun 2020 23:23:59 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-_zG-KxgGMu-O0SQkXWU5mQ-1; Mon, 29 Jun 2020 19:23:56 -0400 X-MC-Unique: _zG-KxgGMu-O0SQkXWU5mQ-1 Received: by mail-ed1-f65.google.com with SMTP id g20so14264899edm.4 for ; Mon, 29 Jun 2020 16:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sHKzrk/z/kMGPeyIpM+M4V0Dj+/IWbE197hNLvsYk+s=; b=cH5rZM48Np/Jwv7v5wJOnE/2sbjOYZgdBGZQkyrpo1POzugkvkYqnCUNvA22o/TC8X F7/wkdaDIZG+ytsbpKxH7CCO81d96AuDah0nkqSUVTqk7T0/3lMrJI92D4I/Hqb4PmKH OxSbPyA4zMbwgxczDMTwttHTE8XTi9fExNMlxxZneD8F7jTzoVR0Ii60bOYNW19pRtSV POJrd4CrZA9iZOzzLXsTIBCo1zYPnEEH5ijPUVAGLZtSha+2Qi+yp6d/AIo/eTFxdFl8 zkwHAou5zk5dLQf7+VZVVd6mx/bTncTpLqGIIGOb1h8ckug+Q91MNA8Fzqqo8xZpTViU tdKQ== X-Gm-Message-State: AOAM532NEgdeoyGLopTAFocm9jSvUhHI12W6IzcEM2DwXkPV46qev5bp As33+SunbNcsbvymBgHJkk//sNKzZVKpHB8P/F+v X-Google-Smtp-Source: ABdhPJxyA+6RjLsB9FF9dnCzR+IB1u8N4C+wjXzo4Gq6/z6kzwoYhfqAoDIm8F+VuXxiiZdIu2uJmXU5hbA7P0ACG4A= X-Received: by 2002:aa7:d6cf:: with SMTP id x15mr19695792edr.164.1593473035100; Mon, 29 Jun 2020 16:23:55 -0700 (PDT) MIME-Version: 1.0 References: <3eda864fb69977252a061c8c3ccd2d8fcd1f3a9b.1593278952.git.rgb@redhat.com> In-Reply-To: <3eda864fb69977252a061c8c3ccd2d8fcd1f3a9b.1593278952.git.rgb@redhat.com> From: Paul Moore Date: Mon, 29 Jun 2020 19:23:44 -0400 Message-ID: Subject: Re: [PATCH ghak124 v3fix] audit: add gfp parameter to audit_log_nfcfg To: Richard Guy Briggs X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com Cc: fw@strlen.de, LKML , Linux-Audit Mailing List , netfilter-devel@vger.kernel.org, twoerner@redhat.com, Eric Paris , tgraf@infradead.org, dan.carpenter@oracle.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Jun 27, 2020 at 11:25 PM Richard Guy Briggs wrote: > > Fixed an inconsistent use of GFP flags in nft_obj_notify() that used > GFP_KERNEL when a GFP flag was passed in to that function. Given this > allocated memory was then used in audit_log_nfcfg() it led to an audit > of all other GFP allocations in net/netfilter/nf_tables_api.c and a > modification of audit_log_nfcfg() to accept a GFP parameter. > > Reported-by: Dan Carptenter > Signed-off-by: Richard Guy Briggs > --- > Passes audit-testsuite. > > include/linux/audit.h | 8 ++++---- > kernel/auditsc.c | 4 ++-- > net/bridge/netfilter/ebtables.c | 6 +++--- > net/netfilter/nf_tables_api.c | 33 +++++++++++++++++++++------------ > net/netfilter/x_tables.c | 5 +++-- > 5 files changed, 33 insertions(+), 23 deletions(-) Merged into audit/next. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit