From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90388C433E0 for ; Thu, 25 Jun 2020 19:15:24 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E1AB2065D for ; Thu, 25 Jun 2020 19:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dsamg2mU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E1AB2065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593112523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zrwuuTuqbWzqxcUI+8IioElwkVsRvxH8w9ziG1XuwTM=; b=Dsamg2mUFv4hEe5Ad04OG17xW/HyC1oisQjqf3hkQ74YB41jHn90S01/Cll7TAbJr926Co MmyRaOQVTPbUUkVAPKcmq7anzTxcZhjX3AMeGz7XecTheXUCi9fLha1ti2hptvLA5wAxiC JJzVW5yioDpo9DeBsbMbefrxlKE8Bho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-kmKdfAbFPT2DfkVrGwaT7g-1; Thu, 25 Jun 2020 15:15:01 -0400 X-MC-Unique: kmKdfAbFPT2DfkVrGwaT7g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 192498015CB; Thu, 25 Jun 2020 19:14:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EBDD5C578; Thu, 25 Jun 2020 19:14:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 27CDB1809547; Thu, 25 Jun 2020 19:14:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05PJErvw005272 for ; Thu, 25 Jun 2020 15:14:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id C1197F8820; Thu, 25 Jun 2020 19:14:53 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD3A5F84D7 for ; Thu, 25 Jun 2020 19:14:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A3340805C1C for ; Thu, 25 Jun 2020 19:14:51 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-6KK98qBxOlej_ckh6Qc0DQ-1; Thu, 25 Jun 2020 15:14:46 -0400 X-MC-Unique: 6KK98qBxOlej_ckh6Qc0DQ-1 Received: by mail-ed1-f65.google.com with SMTP id e15so5093415edr.2 for ; Thu, 25 Jun 2020 12:14:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pD7cDE1pRowKa97y2ug2GlsIr3bcaoCdNkFbx1fxc3o=; b=SvDpSUyG9fWLgqzAVyMbjZpFuwHN30v//EqXho6X9g+HZMZy3fA0qWcez1D+9RHaCP TcS6skIIuk6AQmHW4lK6TcCBhKUsQe28IsPIB1YJcxOF2JCvH1aRZ3zSdF/XLrft3SAU 8jOT07kwB7hEwJ/FrBNG5Kwp0niQJXgMPNRbovL+WP2A8LspZu4JwQeOyBIIeSgcClhy SkfAwDkTmyZwRIgXuhy7BtGWLj/Ykj6JxBJ2H4bHrJvFvl0xF0kSuebVP8p8tq01bC27 jL/LcnYoikOSlQBGXkWBOAdaB7ZF+uKY8aAI4hG7ZY7+ICd8LDOvYr9b7RUvC+l2haVH BSGw== X-Gm-Message-State: AOAM532AAr511DrEwQdNqPSiaviC1p8VJh6myOwr7V5ZxuYZdApS6/He 12PmJau0f27MllBI7LkL495KP0ZmARwtvN2ekZ/z X-Google-Smtp-Source: ABdhPJwBF+4tgJZEQxIu8g09LpmP3KY3mtsOD8kLQZvMUBINU09oYuesxtYvtDT3DUBp28CQyH/S4RxLZI9OlHqM0Ig= X-Received: by 2002:aa7:cd52:: with SMTP id v18mr27675622edw.196.1593112485180; Thu, 25 Jun 2020 12:14:45 -0700 (PDT) MIME-Version: 1.0 References: <20200618211012.2823-1-nramas@linux.microsoft.com> <20200618211012.2823-2-nramas@linux.microsoft.com> <1592942295.5389.9.camel@linux.ibm.com> <39d66bdc-55be-984a-42a0-34d0a011e0fb@linux.microsoft.com> In-Reply-To: <39d66bdc-55be-984a-42a0-34d0a011e0fb@linux.microsoft.com> From: Paul Moore Date: Thu, 25 Jun 2020 15:14:34 -0400 Message-ID: Subject: Re: [PATCH v3 2/2] IMA: Add audit log for failure conditions To: Lakshmi Ramasubramanian X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: linux-audit@redhat.com Cc: rgb@redhat.com, linux-kernel@vger.kernel.org, Mimi Zohar , linux-audit@redhat.com, linux-integrity@vger.kernel.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 24, 2020 at 1:25 PM Lakshmi Ramasubramanian wrote: > > On 6/23/20 12:58 PM, Mimi Zohar wrote: > > Hi Steve\Paul, > > >> Sample audit messages: > >> > >> [ 6.303048] audit: type=1804 audit(1592506281.627:2): pid=1 uid=0 > >> auid=4294967295 ses=4294967295 subj=kernel op=measuring_key > >> cause=ENOMEM comm="swapper/0" name=".builtin_trusted_keys" res=0 > >> errno=-12 > > > > My only concern is that auditing -ENOMEM will put additional memory > > pressure on the system. I'm not sure if this is a concern and, if so, > > how it should be handled. > > Do you have any concerns with respect to adding audit messages in low > memory conditions? Assuming the system is not completely toast, the allocation failure could be a very transient issue; I wouldn't worry too much about it. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit