From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77EF4C2B9F7 for ; Mon, 24 May 2021 23:08:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F41086140F for ; Mon, 24 May 2021 23:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F41086140F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-zQLBFhFROgGpgMnVfYOPrA-1; Mon, 24 May 2021 19:08:36 -0400 X-MC-Unique: zQLBFhFROgGpgMnVfYOPrA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22E1D501E0; Mon, 24 May 2021 23:08:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 054335D71D; Mon, 24 May 2021 23:08:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0421055355; Mon, 24 May 2021 23:08:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14ON8U2l009868 for ; Mon, 24 May 2021 19:08:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 732D21111C88; Mon, 24 May 2021 23:08:30 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30E8A1111C8B for ; Mon, 24 May 2021 23:08:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D896E800B26 for ; Mon, 24 May 2021 23:08:27 +0000 (UTC) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-MQM_YLZqN0mlepfmYQ5S_g-1; Mon, 24 May 2021 19:08:25 -0400 X-MC-Unique: MQM_YLZqN0mlepfmYQ5S_g-1 Received: by mail-ej1-f51.google.com with SMTP id gb17so26231106ejc.8 for ; Mon, 24 May 2021 16:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XiMGNxYXobq8k1+6Xs4DhDuG+BuLQq/LJhQhViCVuGs=; b=WZWX58djvWhQUNJi38qZI68dB4SYD9v8qrhh4VZmkk+FyIAH+YbjYrbQZ75sLCiuis TxgZezSryWl+N6WCOKshkGaqoRUblbcfF3230s0slYW9+kvZxM2eCQe7SPe3fIogNI+2 6/IB9mHIrfm9kqrUG25pkKWW5cVdGbfNBXByPMVD69+is4semi0IIQ1eO4RXZ80cajXl EcpRQycHgeM15Ug3yrJyD/UmwVWH0vwkC0C6vwb/7/NxrgHmWiSD+h1aaZe8sl0KnZkj NNT/psFzFVxP3OLvs4WfcJjcZKtx/PbBmHjKmg2O7ktynnZe6kW5A1EzgkhaW9hw94d8 vAUQ== X-Gm-Message-State: AOAM532gYxQghWECF9k8mwgq/s6Eofh2J6wjnqdqlcPbDcVAGGnpLD0c +1xj6PSDMSTFlaonN3JkifVqXXHMtuSAhWwxBim52Ho7xQ== X-Google-Smtp-Source: ABdhPJzzwj1n5e/zHh1DggqILVebXbU0R+v7/LHNPOFDR+3B3V3XP+is9w9Ox0FsIAkeF75AH8u4DYZr5NhmhT4fvMw= X-Received: by 2002:a17:907:1749:: with SMTP id lf9mr26453028ejc.178.1621897704595; Mon, 24 May 2021 16:08:24 -0700 (PDT) MIME-Version: 1.0 References: <20210520080318.owvsvvhh5qdhyzhk@wittgenstein> In-Reply-To: <20210520080318.owvsvvhh5qdhyzhk@wittgenstein> From: Paul Moore Date: Mon, 24 May 2021 19:08:13 -0400 Message-ID: Subject: Re: [PATCH v4 3/3] audit: add OPENAT2 record to list how To: Christian Brauner X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 14ON8U2l009868 X-loop: linux-audit@redhat.com Cc: Richard Guy Briggs , LKML , Eric Paris , Aleksa Sarai , Linux-Audit Mailing List , Alexander Viro , linux-fsdevel@vger.kernel.org, Eric Paris X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 20, 2021 at 4:03 AM Christian Brauner wrote: > On Wed, May 19, 2021 at 04:00:22PM -0400, Richard Guy Briggs wrote: > > Since the openat2(2) syscall uses a struct open_how pointer to communicate > > its parameters they are not usefully recorded by the audit SYSCALL record's > > four existing arguments. > > > > Add a new audit record type OPENAT2 that reports the parameters in its > > third argument, struct open_how with fields oflag, mode and resolve. > > > > The new record in the context of an event would look like: > > time->Wed Mar 17 16:28:53 2021 > > type=PROCTITLE msg=audit(1616012933.531:184): proctitle=73797363616C6C735F66696C652F6F70656E617432002F746D702F61756469742D7465737473756974652D737641440066696C652D6F70656E617432 > > type=PATH msg=audit(1616012933.531:184): item=1 name="file-openat2" inode=29 dev=00:1f mode=0100600 ouid=0 ogid=0 rdev=00:00 obj=unconfined_u:object_r:user_tmp_t:s0 nametype=CREATE cap_fp=0 cap_fi=0 cap_fe=0 cap_fver=0 cap_frootid=0 > > type=PATH msg=audit(1616012933.531:184): item=0 name="/root/rgb/git/audit-testsuite/tests" inode=25 dev=00:1f mode=040700 ouid=0 ogid=0 rdev=00:00 obj=unconfined_u:object_r:user_tmp_t:s0 nametype=PARENT cap_fp=0 cap_fi=0 cap_fe=0 cap_fver=0 cap_frootid=0 > > type=CWD msg=audit(1616012933.531:184): cwd="/root/rgb/git/audit-testsuite/tests" > > type=OPENAT2 msg=audit(1616012933.531:184): oflag=0100302 mode=0600 resolve=0xa > > type=SYSCALL msg=audit(1616012933.531:184): arch=c000003e syscall=437 success=yes exit=4 a0=3 a1=7ffe315f1c53 a2=7ffe315f1550 a3=18 items=2 ppid=528 pid=540 auid=0 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=ttyS0 ses=1 comm="openat2" exe="/root/rgb/git/audit-testsuite/tests/syscalls_file/openat2" subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 key="testsuite-1616012933-bjAUcEPO" > > > > Signed-off-by: Richard Guy Briggs > > Link: https://lore.kernel.org/r/d23fbb89186754487850367224b060e26f9b7181.1621363275.git.rgb@redhat.com > > --- > > fs/open.c | 2 ++ > > include/linux/audit.h | 10 ++++++++++ > > include/uapi/linux/audit.h | 1 + > > kernel/audit.h | 2 ++ > > kernel/auditsc.c | 18 +++++++++++++++++- > > 5 files changed, 32 insertions(+), 1 deletion(-) ... > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > > index 3f59ab209dfd..faf2485323a9 100644 > > --- a/kernel/auditsc.c > > +++ b/kernel/auditsc.c > > @@ -76,7 +76,7 @@ > > #include > > #include > > #include > > -#include > > +#include // struct open_how > > > > #include "audit.h" > > > > @@ -1319,6 +1319,12 @@ static void show_special(struct audit_context *context, int *call_panic) > > audit_log_format(ab, "fd=%d flags=0x%x", context->mmap.fd, > > context->mmap.flags); > > break; > > + case AUDIT_OPENAT2: > > + audit_log_format(ab, "oflag=0%llo mode=0%llo resolve=0x%llx", > > Hm, should we maybe follow the struct member names for all entries, i.e. > replace s/oflag/flags? There is some precedence for using "oflags" to refer to "open" flags, my guess is Richard is trying to be consistent here. I agree it's a little odd, but it looks like the right thing to me from an audit perspective; the audit perspective is a little odd after all :) -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit