linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: rgb@redhat.com, wangweiyang2@huawei.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH -next, v3 1/2] audit: fix possible null-pointer dereference in audit_filter_rules
Date: Mon, 18 Oct 2021 18:28:55 -0400	[thread overview]
Message-ID: <CAHC9VhRrVoKn43F4KdWVp9_mJ8Kv9azvptiBkSTdBx+YcnW5ww@mail.gmail.com> (raw)
In-Reply-To: <20211016072351.237745-2-cuigaosheng1@huawei.com>

On Sat, Oct 16, 2021 at 3:21 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
>
> Fix  possible null-pointer dereference in audit_filter_rules.
>
> audit_filter_rules() error: we previously assumed 'ctx' could be null
>
> Fixes: bf361231c295 ("audit: add saddr_fam filter field")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  kernel/auditsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you for the patch; I added a stable tag and merged it into
audit/stable-5.15, I'll send it up to Linus later this week once it
has gone through some additional testing.

-- 
paul moore
www.paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2021-10-18 22:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-16  7:23 [PATCH -next,v3 0/2] Audit: fix warning and check priority early Gaosheng Cui
2021-10-16  7:23 ` [PATCH -next, v3 1/2] audit: fix possible null-pointer dereference in audit_filter_rules Gaosheng Cui
2021-10-18 22:28   ` Paul Moore [this message]
2021-10-16  7:23 ` [PATCH -next, v3 2/2] audit: return early if the rule has a lower priority Gaosheng Cui
2021-10-18 22:38   ` Paul Moore
2021-10-19 14:51   ` Steve Grubb
2021-10-19 14:53     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhRrVoKn43F4KdWVp9_mJ8Kv9azvptiBkSTdBx+YcnW5ww@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=cuigaosheng1@huawei.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgb@redhat.com \
    --cc=wangweiyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).