linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
* [PATCH] kernel/auditsc: remove unused header file
@ 2021-07-30  7:52 Hui Su
  2021-08-02 13:54 ` Paul Moore
  0 siblings, 1 reply; 2+ messages in thread
From: Hui Su @ 2021-07-30  7:52 UTC (permalink / raw)
  To: paul, eparis, linux-audit, linux-kernel; +Cc: Hui Su

Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64()
for time access"), the linux/time.h is unused.

Signed-off-by: Hui Su <suhui@zeku.com>
---
 kernel/auditsc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 8dd73a64f921..33bb6a83baf1 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -57,7 +57,6 @@
 #include <linux/mqueue.h>
 #include <linux/audit.h>
 #include <linux/personality.h>
-#include <linux/time.h>
 #include <linux/netlink.h>
 #include <linux/compiler.h>
 #include <asm/unistd.h>
-- 
2.30.2


--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kernel/auditsc: remove unused header file
  2021-07-30  7:52 [PATCH] kernel/auditsc: remove unused header file Hui Su
@ 2021-08-02 13:54 ` Paul Moore
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2021-08-02 13:54 UTC (permalink / raw)
  To: Hui Su; +Cc: linux-audit, linux-kernel, Eric Paris

On Fri, Jul 30, 2021 at 3:52 AM Hui Su <suhui@zeku.com> wrote:
>
> Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64()
> for time access"), the linux/time.h is unused.
>
> Signed-off-by: Hui Su <suhui@zeku.com>
> ---
>  kernel/auditsc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 8dd73a64f921..33bb6a83baf1 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -57,7 +57,6 @@
>  #include <linux/mqueue.h>
>  #include <linux/audit.h>
>  #include <linux/personality.h>
> -#include <linux/time.h>
>  #include <linux/netlink.h>
>  #include <linux/compiler.h>
>  #include <asm/unistd.h>

At the very least the kernel/auditsc.c file still makes use of the
timespec64 struct which is defined in include/linux/time64.h which is
brought in by include/linux/time.h and *not* by
include/linux/timekeeping.h.  As long as we make use of the timespec64
struct and the definition remains in time64.h let's keep the time.h
include.

-- 
paul moore
www.paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-02 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30  7:52 [PATCH] kernel/auditsc: remove unused header file Hui Su
2021-08-02 13:54 ` Paul Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).