From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78058C4338F for ; Mon, 2 Aug 2021 13:55:01 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6D1860F50 for ; Mon, 2 Aug 2021 13:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6D1860F50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-vbUQtCoWNvu_BGFvCKeU5w-1; Mon, 02 Aug 2021 09:54:58 -0400 X-MC-Unique: vbUQtCoWNvu_BGFvCKeU5w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F86287D542; Mon, 2 Aug 2021 13:54:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B7DC60C82; Mon, 2 Aug 2021 13:54:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE1B94BB7C; Mon, 2 Aug 2021 13:54:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 172DsjMB032249 for ; Mon, 2 Aug 2021 09:54:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 21279202F342; Mon, 2 Aug 2021 13:54:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 197D6202F33D for ; Mon, 2 Aug 2021 13:54:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 427E68CA947 for ; Mon, 2 Aug 2021 13:54:38 +0000 (UTC) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-LQU6QTzION2tJMeI7b7EIg-1; Mon, 02 Aug 2021 09:54:35 -0400 X-MC-Unique: LQU6QTzION2tJMeI7b7EIg-1 Received: by mail-ej1-f45.google.com with SMTP id go31so30956649ejc.6 for ; Mon, 02 Aug 2021 06:54:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EpJO592WYEixrqXzIZb7goGYROImopIKrr17z7H5HQw=; b=JqFJH/ttkMns/bSSz1e0kl4i1DcZtut7RkB2K/I5pvOGGzanMbTVJ9LCsLAVg5rHrv q3LhVUqejmHlferjVtWUPFNMaP9Nu8axg6MPKUL2ti50MmVasOQpBQoN/tSg+mmtRNej Uis7ZOLz6gSRFRPLEcuvhpm+bMyQS7kY8zJnyPJcy23C97gfc2vqYWsGwwoFGTZ6coKl doCyvrR2ppZQIJ/lNEQJ78pWTf9VR+RKaY+wGOPHoAdTZ+sPP8rf0pO5fxDY3+gHbP9E Yd7yAZIn4P5K08OLkaLi30zWobOQ/vK7I7SIAutRVnsX4p8CBW4vmVVj+vOEusTduk1v FLmg== X-Gm-Message-State: AOAM532EuSnGqyREn4mek7JAPshrskkL9jJ/QwQ52hGDK2MJGgA4TwL+ xWZZaWczfpQSqPicdJ2hcrKQEEo7hgSWSZ+zrX7l X-Google-Smtp-Source: ABdhPJz40sJlqZEGviQHkm6Qn1c/GD/pz8OCJuU8LwiwWCKf03ePdsNkKAdpoH9hMlUREjbu0ZjfO+uC3SDrk2bUV/U= X-Received: by 2002:a17:906:4ad9:: with SMTP id u25mr15537798ejt.106.1627912474320; Mon, 02 Aug 2021 06:54:34 -0700 (PDT) MIME-Version: 1.0 References: <20210730075234.338-1-suhui@zeku.com> In-Reply-To: <20210730075234.338-1-suhui@zeku.com> From: Paul Moore Date: Mon, 2 Aug 2021 09:54:23 -0400 Message-ID: Subject: Re: [PATCH] kernel/auditsc: remove unused header file To: Hui Su X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, Eric Paris X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 30, 2021 at 3:52 AM Hui Su wrote: > > Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64() > for time access"), the linux/time.h is unused. > > Signed-off-by: Hui Su > --- > kernel/auditsc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 8dd73a64f921..33bb6a83baf1 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -57,7 +57,6 @@ > #include > #include > #include > -#include > #include > #include > #include At the very least the kernel/auditsc.c file still makes use of the timespec64 struct which is defined in include/linux/time64.h which is brought in by include/linux/time.h and *not* by include/linux/timekeeping.h. As long as we make use of the timespec64 struct and the definition remains in time64.h let's keep the time.h include. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit