From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39735C433E0 for ; Sun, 21 Feb 2021 22:13:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA67D64DDA for ; Sun, 21 Feb 2021 22:13:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA67D64DDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-nrkUWCeoMai2JBP5UpaZYQ-1; Sun, 21 Feb 2021 17:13:01 -0500 X-MC-Unique: nrkUWCeoMai2JBP5UpaZYQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B0EF18449E7; Sun, 21 Feb 2021 22:12:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67BA961F47; Sun, 21 Feb 2021 22:12:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 131D14EE7F; Sun, 21 Feb 2021 22:12:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11LMCbPi032306 for ; Sun, 21 Feb 2021 17:12:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6A41F1112842; Sun, 21 Feb 2021 22:12:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6647D1112840 for ; Sun, 21 Feb 2021 22:12:34 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D29AD85A59D for ; Sun, 21 Feb 2021 22:12:34 +0000 (UTC) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-WJea4YwuMAGiq_vTi9_aHg-1; Sun, 21 Feb 2021 17:12:32 -0500 X-MC-Unique: WJea4YwuMAGiq_vTi9_aHg-1 Received: by mail-ej1-f48.google.com with SMTP id u20so25468207ejb.7 for ; Sun, 21 Feb 2021 14:12:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JHLbwT/ysBdqWf/COmA52ux7qzFg6vWUUO9UK965XT8=; b=AOlNcQa1p2IgLCoUm5eBm2/g2u3j2IkwYiAOpIIs4PfY4LzjnoiHycqA05TXvXUeIw cQn/3ugnrIxyPHMX1u2j6ICEAi1s5Ymxd0gJboKCJh+txI33mBhGzPabTaBKcKTMeG6P b/56vieY07Ih7R1aL/8SpXBlnKwhVgvDVGuCsO1S2BerGFaH3KKHoFCU4+GvqZUsixXw uJiZUZvJr3S3790JGpv9Vb8cd/DFJm59fsIdsoFWWAcgl7ydomjRRh8NT+u0136AGYQR 9C1bEEzyhjRsCTwUI1AQfrzRY0M9ogrD87e8vhlpCPZyf1Rc1PIt/N5e7yqrIEYMw0zO bZ/w== X-Gm-Message-State: AOAM532T5/6lzRl5eRF0qQ3wV0qM2hjKlUScONvzpSKbyZSLmMV61CkK X18bIDOTOh8fLhm2xzOOOLSu08E251UeRcxQi0KP X-Google-Smtp-Source: ABdhPJzC8AgWl6lkNnXnwDrKhO1kGPO9s6ErhPfRwnjbiInC6c1hcYVpWVaXQNi3+Iu7IaJg76JIBWJv0tqMaclUMiE= X-Received: by 2002:a17:906:8394:: with SMTP id p20mr18467935ejx.178.1613945551482; Sun, 21 Feb 2021 14:12:31 -0800 (PST) MIME-Version: 1.0 References: <161377712068.87807.12246856567527156637.stgit@sifl> <161377736385.87807.7033400948278183233.stgit@sifl> <28174118-93d2-e7a5-50fb-004185354625@canonical.com> In-Reply-To: <28174118-93d2-e7a5-50fb-004185354625@canonical.com> From: Paul Moore Date: Sun, 21 Feb 2021 17:12:19 -0500 Message-ID: Subject: Re: [RFC PATCH 4/4] apparmor: differentiate between subjective and objective task credentials To: John Johansen X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: linux-audit@redhat.com Cc: selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Feb 21, 2021 at 7:57 AM John Johansen wrote: > On 2/19/21 3:29 PM, Paul Moore wrote: > > With the split of the security_task_getsecid() into subjective and > > objective variants it's time to update AppArmor to ensure it is > > using the correct task creds. > > > > Signed-off-by: Paul Moore > > This has a couple problems, that I will work on addressing Yes, I figured that might be the case; I don't have enough understanding of the AppArmor internals to do anything more than a ham fisted approach - my apologies on that. Let me know if there is anything I can do to help. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit