From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB1FC47094 for ; Mon, 7 Jun 2021 18:18:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 434E361003 for ; Mon, 7 Jun 2021 18:18:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 434E361003 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-0Ai6S4OrO6an0kvr4rJyfg-1; Mon, 07 Jun 2021 14:18:28 -0400 X-MC-Unique: 0Ai6S4OrO6an0kvr4rJyfg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36F88106BB37; Mon, 7 Jun 2021 18:18:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C890159443; Mon, 7 Jun 2021 18:18:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E520F380B; Mon, 7 Jun 2021 18:18:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 157IIK95028585 for ; Mon, 7 Jun 2021 14:18:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 92E96205D6B6; Mon, 7 Jun 2021 18:18:20 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F31B205D6B5 for ; Mon, 7 Jun 2021 18:18:17 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3FDA01857F29 for ; Mon, 7 Jun 2021 18:18:17 +0000 (UTC) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-d_7ZHFJdOvapYbWLUi9tcw-1; Mon, 07 Jun 2021 14:18:15 -0400 X-MC-Unique: d_7ZHFJdOvapYbWLUi9tcw-1 Received: by mail-ej1-f42.google.com with SMTP id g20so28286480ejt.0 for ; Mon, 07 Jun 2021 11:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sbUSJqSbut0v53C0fNrpLk5VXvw0k+vSP9xx9sgALVo=; b=PmIowbGAxeX5e81fo1+p4UaYAjxjXiIUpm6vhILbf7DIZT6NzfWLgHOXyPjW9xuGn8 oIPM3FVYZfWIp3oOSP8vpI55GnlV0WLcoq5S3jAjsFDSv7EMuGi721b8tijxkDc3f7B3 wIXTz4VH34uDVWwMfOd2P9b3PxYdwkrRejzRPWSvgrQQVshGOgRH6UR5zyDTeK42Q1sq B8VXb8xcJBt19Lo0792wM9wWM/tov12fKAtEIHfKMhlRn8H40Z2QSixve/SdRujV2Jxj zeLriZCytMa6fbOmMyowU+c5kLf1UQCsoXTQ+QIDLE7hT9eUoRBKbAcHPMDpg44D725N zEdQ== X-Gm-Message-State: AOAM533zaT9AqCYINs1njDvvqJJp4YbdwcwuyQyQNAWfis1UDaJLSCyX hN9KY4G6oYeMv+lx6O25G/a7pogCMfdvDdLmQ8yi X-Google-Smtp-Source: ABdhPJz6c/ZosOHRZERkjdb1ufocxhI1igSKtTjAxQvHM7XCX4fzbRWL/97g88yUm4Y7XAlJmKuAgVUcVme+Ub1rjyg= X-Received: by 2002:a17:906:2c54:: with SMTP id f20mr19221773ejh.91.1623089893673; Mon, 07 Jun 2021 11:18:13 -0700 (PDT) MIME-Version: 1.0 References: <79d5bffd63b46bb7d54ebcef4765cfca28f76ff0.camel@yandex.ru> <20210607175058.GO447005@madcap2.tricolour.ca> In-Reply-To: <20210607175058.GO447005@madcap2.tricolour.ca> From: Paul Moore Date: Mon, 7 Jun 2021 14:18:02 -0400 Message-ID: Subject: Re: [PATCH] audit: Rename enum audit_state constants to avoid AUDIT_DISABLED redefinition To: Richard Guy Briggs X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com Cc: Sergey Nazarov , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Eric Paris X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jun 7, 2021 at 1:51 PM Richard Guy Briggs wrote: > On 2021-06-07 13:07, Paul Moore wrote: > > On Mon, Jun 7, 2021 at 5:58 AM Sergey Nazarov wrote: > > > Hi, Paul! > > > I think this could be easer. It's enouth to rename AUDIT_DISABLE only. > > > enum audit_state deals with per-task syscalls audit context, so we can > > > use AUDIT_CONTEXT_DISABLED for example. If it's okay, I can send a new > > > patch version. > > > > Hi Sergey, > > > > I personally prefer the AUDIT_STATE_* enums and would rather see that. > > I find AUDITSC_* or AUDIT*CONTEXT* are more helpful since that makes it > clear it is about syscall context while STATE doesn't make that clear. We've seen how this will grow to incorporate more than just a syscall context, see the io_uring work that is ongoing. Let me be very clear this time, please use the AUDIT_STATE_* enums. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit