From: Paul Moore <paul@paul-moore.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] audit: Remove leftover reference to the audit_tasklet
Date: Fri, 15 Jan 2021 12:08:50 -0500 [thread overview]
Message-ID: <CAHC9VhS=f93bcHQMtrpvEM=aqyKFf8gjRGpM6QkOO4r2gEpuCw@mail.gmail.com> (raw)
In-Reply-To: <20210115001201.116832-1-dave@stgolabs.net>
On Thu, Jan 14, 2021 at 7:12 PM Davidlohr Bueso <dave@stgolabs.net> wrote:
>
> This was replaced with a kauditd_wait kthread long ago,
> back in:
>
> b7d1125817c (AUDIT: Send netlink messages from a separate kernel thread)
>
> Update the stale comment.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> kernel/audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch. Merged into audit/next, thanks!
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 1ffc2e059027..8fd735190c12 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -2365,7 +2365,7 @@ int audit_signal_info(int sig, struct task_struct *t)
> *
> * We can not do a netlink send inside an irq context because it blocks (last
> * arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is placed on a
> - * queue and a tasklet is scheduled to remove them from the queue outside the
> + * queue and a kthread is scheduled to remove them from the queue outside the
> * irq context. May be called in any context.
> */
> void audit_log_end(struct audit_buffer *ab)
> --
> 2.26.2
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2021-01-15 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 0:12 [PATCH] audit: Remove leftover reference to the audit_tasklet Davidlohr Bueso
2021-01-15 17:08 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhS=f93bcHQMtrpvEM=aqyKFf8gjRGpM6QkOO4r2gEpuCw@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).