From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE8DC2B9F7 for ; Fri, 28 May 2021 16:03:24 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3662C611AB for ; Fri, 28 May 2021 16:03:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3662C611AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402--HWP7WWTPOOADBaiD2_PzA-1; Fri, 28 May 2021 12:03:21 -0400 X-MC-Unique: -HWP7WWTPOOADBaiD2_PzA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8EB62180FD62; Fri, 28 May 2021 16:03:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B81318A9E; Fri, 28 May 2021 16:03:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EE6C61800BB4; Fri, 28 May 2021 16:03:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14SG3GZF009801 for ; Fri, 28 May 2021 12:03:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id ED9EE1692DB; Fri, 28 May 2021 16:03:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E875D107514 for ; Fri, 28 May 2021 16:03:13 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78F46800B26 for ; Fri, 28 May 2021 16:03:13 +0000 (UTC) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-b6Z7PIeuOo2eOvlOnhHsPQ-1; Fri, 28 May 2021 12:03:10 -0400 X-MC-Unique: b6Z7PIeuOo2eOvlOnhHsPQ-1 Received: by mail-ej1-f42.google.com with SMTP id h24so2165830ejy.2 for ; Fri, 28 May 2021 09:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n2mkp1VfbRLXyX9BQ4/sufzNob6zQwJ5kWZnckwzjKg=; b=MqQnYwjC7kDjq7wGJ04o5i0f4vZg7yDiW+Rsm6kg8Jovj9sG+WepN9Z3/PFbdYxwdo emsa0JrkFG+qC6av9px/szECgWlpJ6FAyYSDpQOATspZmTISBRKf1KE92Qhyb6N5gh7y 7d6RAY+WN96DUICnZzKzHoSDPoZ3f/5NzjnCjJCHmc8OOcCOvb5ANnu5InLDZ7I+ZQAL Hs5SAj7/GPzkB5n/gdTMP7pQAteDYk7IXoLEhedOfRcOD5dXmBHdtwjWZ4NRf+fa29f6 +e/zijWHMUwb4/YXg6JmD2SEi3NZuRYJprlmxWvz+5f5L4c/2qy/pY32pRD0IcyJnpXJ MrAA== X-Gm-Message-State: AOAM533zUL8v5qqmc/W/jIF4E0xDukgE/dpf0KzRbEhMLIXD2qrmVCCE rU9D1I+IOvzhDU2ZshkL6EQBYqBOV+u7rGQmFoAh X-Google-Smtp-Source: ABdhPJxRjX3Ws7VBEcmMgQB006OahZcwDvgkWQ9e4I1WzulhYU5E4GfGyPMI6cxRYYL7k/JKuuFBrGiK18GyCTgkyuA= X-Received: by 2002:a17:906:4111:: with SMTP id j17mr150091ejk.488.1622217789328; Fri, 28 May 2021 09:03:09 -0700 (PDT) MIME-Version: 1.0 References: <162163367115.8379.8459012634106035341.stgit@sifl> <162163379461.8379.9691291608621179559.stgit@sifl> <162219f9-7844-0c78-388f-9b5c06557d06@gmail.com> <8943629d-3c69-3529-ca79-d7f8e2c60c16@kernel.dk> <9e69e4b6-2b87-a688-d604-c7f70be894f5@kernel.dk> <3bef7c8a-ee70-d91d-74db-367ad0137d00@kernel.dk> In-Reply-To: From: Paul Moore Date: Fri, 28 May 2021 12:02:58 -0400 Message-ID: Subject: Re: [RFC PATCH 2/9] audit,io_uring,io-wq: add some basic audit support to io_uring To: Jens Axboe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: linux-audit@redhat.com Cc: selinux@vger.kernel.org, io-uring@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, Kumar Kartikeya Dwivedi , linux-fsdevel@vger.kernel.org, Pavel Begunkov , Alexander Viro X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 26, 2021 at 4:19 PM Paul Moore wrote: > ... If we moved the _entry > and _exit calls into the individual operation case blocks (quick > openat example below) so that only certain operations were able to be > audited would that be acceptable assuming the high frequency ops were > untouched? My initial gut feeling was that this would involve >50% of > the ops, but Steve Grubb seems to think it would be less; it may be > time to look at that a bit more seriously, but if it gets a NACK > regardless it isn't worth the time - thoughts? > > case IORING_OP_OPENAT: > audit_uring_entry(req->opcode); > ret = io_openat(req, issue_flags); > audit_uring_exit(!ret, ret); > break; I wanted to pose this question again in case it was lost in the thread, I suspect this may be the last option before we have to "fix" things at the Kconfig level. I definitely don't want to have to go that route, and I suspect most everyone on this thread feels the same, so I'm hopeful we can find a solution that is begrudgingly acceptable to both groups. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit