From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADA0C433F5 for ; Thu, 4 Nov 2021 14:33:30 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B153F604D2 for ; Thu, 4 Nov 2021 14:33:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B153F604D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-cCf8RhmfNzmuHxXAccIMzw-1; Thu, 04 Nov 2021 10:33:25 -0400 X-MC-Unique: cCf8RhmfNzmuHxXAccIMzw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD46887D542; Thu, 4 Nov 2021 14:33:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EEF76784F; Thu, 4 Nov 2021 14:33:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F2AA04EA2F; Thu, 4 Nov 2021 14:33:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A4EXGZb016204 for ; Thu, 4 Nov 2021 10:33:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id E937F2026D6B; Thu, 4 Nov 2021 14:33:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E349B2026D69 for ; Thu, 4 Nov 2021 14:33:12 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCBB118A01B1 for ; Thu, 4 Nov 2021 14:33:12 +0000 (UTC) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-eafPhgbDOJ-bybFG07l2TA-1; Thu, 04 Nov 2021 10:33:10 -0400 X-MC-Unique: eafPhgbDOJ-bybFG07l2TA-1 Received: by mail-ed1-f43.google.com with SMTP id o8so22047143edc.3 for ; Thu, 04 Nov 2021 07:33:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lxqQEO/rT8vCYvc8shTb7+5KlfliNzIt+0I9iwl8MAo=; b=pT6ijjqDt5m5XNwqC80N0HQt41WqYzwUEevDpfb/utNiK/cNoW2Gi/5qEeWEke5KbV IJ1BHJfrERVsipAIPjsWdDTjDXfitDNqZgOcvH7K/uVNCDmG9OuKW3wVvq4BwdTh/L0L aYtf+0IzDk6JT1oaZeeKylTlKmpc8nzFrNHyhbuJe5Cbf6og6FhQV5y8EqY20NzqmZgQ hRgF5mm1jc8QDLpfbVuxSAQhUJW/jejwmehdYAo+b8Dz3fFdyeAUSdsubgBq42J2ABqq XSZssxerkenUlxxRzaPYJl1CbzFBikE5s8o048mYQRrO9yNCBUKfpU6Kc8Mpw9XivpIQ xYkA== X-Gm-Message-State: AOAM530KUyHduGgArG+jp3BOneYe88+3rbLkjXIhbMKDT75pwaRu+6fl Ee3zoAuvezuVelLVh/TLbygyxHvL/dT0VJ68y7F55GYTVA== X-Google-Smtp-Source: ABdhPJwE13mGNmySljOzUaHZss3NKTk1pkR2BMQqKnkop5Bli+fJLDi2R01BTeWo+lIIwuW3sMwj52Z3kphzbdOTwmc= X-Received: by 2002:a17:907:868f:: with SMTP id qa15mr37133631ejc.187.1636036386968; Thu, 04 Nov 2021 07:33:06 -0700 (PDT) MIME-Version: 1.0 References: <163584790624.1845480.1785827913484538939.b4-ty@ellerman.id.au> <87a6im87tq.fsf@mpe.ellerman.id.au> <20211102235449.rwtbgmddkzdaodhv@meerkat.local> <871r3w8msd.fsf@mpe.ellerman.id.au> In-Reply-To: <871r3w8msd.fsf@mpe.ellerman.id.au> From: Paul Moore Date: Thu, 4 Nov 2021 10:32:55 -0400 Message-ID: Subject: Re: [PATCH v2 RESEND] powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC To: Michael Ellerman X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com Cc: Benjamin Herrenschmidt , patch-notifications@ellerman.id.au, linux-kernel@vger.kernel.org, Christophe Leroy , linux-audit@redhat.com, Paul Mackerras , Eric Paris , linuxppc-dev@lists.ozlabs.org, Konstantin Ryabitsev X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 4, 2021 at 2:20 AM Michael Ellerman wrote: > Konstantin Ryabitsev writes: > > On Wed, Nov 03, 2021 at 10:18:57AM +1100, Michael Ellerman wrote: > >> It's not in next, that notification is from the b4 thanks script, which > >> didn't notice that the commit has since been reverted. > > > > Yeah... I'm not sure how to catch that, but I'm open to suggestions. > > I think that's probably the first time I've had a commit and a revert of > the commit in the same batch of thanks mails. > > And the notification is not wrong, the commit was applied with that SHA, > it is in the tree. > > So I'm not sure it's very common to have a commit & a revert in the tree > at the same time. I know it is not common for the SELinux and audit trees. I guess every tree/maintainer is different, but I'm probably more conservative than most when it comes to merging patches so it's pretty rare that we need to revert things in those trees. > On the other hand being able to generate a mail for an arbitrary revert > would be helpful, ie. independent of any thanks state. > > eg, picking a random commit from the past: > > e95ad5f21693 ("powerpc/head_check: Fix shellcheck errors") > > If I revert that in my tree today, it'd be cool if I could run something > that would detect the revert, backtrack to the reverted commit, extract > the message-id from the Link: tag, and generate a reply to the original > submission noting that it's now been reverted. Even if it isn't practical to do the find-the-original-commit logic, simply getting an email that says "FYI, this revert has been merged into this tree/branch" would be helpful. Although I guess that would require either the revert having the right metadata, e.g. "Cc:", or that prior mentioned logic to find the original commit so the proper To/CC lines could be generated. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit