From: Paul Moore <paul@paul-moore.com>
To: Sergey Nazarov <s-nazarov@yandex.ru>
Cc: Richard Guy Briggs <rgb@redhat.com>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org,
Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH v2] audit: Rename enum audit_state constants to avoid AUDIT_DISABLED redefinition
Date: Tue, 8 Jun 2021 22:12:13 -0400 [thread overview]
Message-ID: <CAHC9VhT1WGThacDZ=t_yz53yQGUzzXOoFLkBSEcyNzVuAzdp5Q@mail.gmail.com> (raw)
In-Reply-To: <61bf645f5daec5f7096b0c23e5407edf4b3da8a1.camel@yandex.ru>
On Tue, Jun 8, 2021 at 2:32 AM Sergey Nazarov <s-nazarov@yandex.ru> wrote:
>
> AUDIT_DISABLED defined in kernel/audit.h as element of enum audit_state
> and redefined in kernel/audit.c. This produces a warning when kernel builds
> with syscalls audit disabled and brokes kernel build if -Werror used.
> enum audit_state used in syscall audit code only. This patch changes
> enum audit_state constants prefix AUDIT to AUDIT_STATE to avoid
> AUDIT_DISABLED redefinition.
>
> v2: the comments of Richard Guy Briggs and Paul Moore were taken into account
>
> Signed-off-by: Sergey Nazarov <s-nazarov@yandex.ru>
> ---
> kernel/audit.h | 8 ++++----
> kernel/auditsc.c | 34 +++++++++++++++++-----------------
> 2 files changed, 21 insertions(+), 21 deletions(-)
Merged into audit/next, thanks Sergey.
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2021-06-09 2:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 11:21 [PATCH] audit: Rename enum audit_state constants to avoid AUDIT_DISABLED redefinition Sergey Nazarov
2021-06-04 16:17 ` Richard Guy Briggs
2021-06-06 2:40 ` Paul Moore
2021-06-07 9:58 ` Sergey Nazarov
2021-06-07 17:07 ` Paul Moore
2021-06-07 17:50 ` Richard Guy Briggs
2021-06-07 18:18 ` Paul Moore
2021-06-08 6:32 ` [PATCH v2] " Sergey Nazarov
2021-06-08 15:04 ` Richard Guy Briggs
2021-06-09 2:12 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhT1WGThacDZ=t_yz53yQGUzzXOoFLkBSEcyNzVuAzdp5Q@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=s-nazarov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).