From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C043DC43331 for ; Fri, 3 Apr 2020 21:56:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D5572076E for ; Fri, 3 Apr 2020 21:56:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mu6ehH7j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D5572076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585950982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IfIuzCgs7cvgvPMb2JVQl4BqjkVHdEPLgibom5zgQ/A=; b=Mu6ehH7j6cxATouScdF7FrsRD9Dwz+mmRewqn0SLmpPJZueXfFDCbR8g103J1t+yeopb/A kMJduZ9GxIg9vYeUpouy+bRptcsVmVtHlE2ZWjs3M/OMdffWsHmFpskdayV3/wRSiW5Ez5 b0IOQDU+s8XZxXpqpD/ReOjJ1MvUYWs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-QDdgXCDXP22jXPAWFqSvCA-1; Fri, 03 Apr 2020 17:56:14 -0400 X-MC-Unique: QDdgXCDXP22jXPAWFqSvCA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DC531005516; Fri, 3 Apr 2020 21:56:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48D5AB19A6; Fri, 3 Apr 2020 21:56:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 933744E444; Fri, 3 Apr 2020 21:56:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 033LiD1K019707 for ; Fri, 3 Apr 2020 17:44:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id BF80C14E795; Fri, 3 Apr 2020 21:44:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9C8E13D719 for ; Fri, 3 Apr 2020 21:44:11 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3636D8FF663 for ; Fri, 3 Apr 2020 21:44:11 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-5Br3O-D2PVCL7hj6eEk2Ww-1; Fri, 03 Apr 2020 17:44:09 -0400 X-MC-Unique: 5Br3O-D2PVCL7hj6eEk2Ww-1 Received: by mail-ed1-f66.google.com with SMTP id a43so11065919edf.6 for ; Fri, 03 Apr 2020 14:44:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vrK7vwUeUnQBBKtc7jLVryrHjAhV8bpINdD94AtArAQ=; b=PpuS/iMtoWaLxNm1o+E1T+mfMNxCf4zyLgFCYm4/DqgyQmWLr7kWL7oDwNowXIHEq7 IIo6Pqk/ViwO+9aIWIwlRVr8yT8Zm5NsDbpf5A0YHSllDPi4L3/1rhnW20p5l0zilp4M 1on2dcIjv3TgI0s2rG8FuxEITQ6/zLinLYOPkOrFowGlaAQLZUE7Cj5mLvrvaV9vm2AS acEoaXwlm5Lrzn0LDZU5bJYnrOv31DiNdfZvLiFNt8+gIepC7MQRGtHuHzXHQwEmyb6K zuL2HeGRJtH7fF0EJJ2p8yQQXYo4nAAPViAi1soeMShp3tFHV1n3RhY0f8qJVgSGBuqm T2uw== X-Gm-Message-State: AGi0PuYkuepbMBh5GDkh5F7eFIMzuGqxh4ryX0h4PTHbdIi1bgOdibex 9EyjAJ0su2hEtc8lxEJH7xXKz2RXT88OSLU8OmmP X-Google-Smtp-Source: APiQypL59OxS7QNGPWqemd6Y/5Vu/44PzNASHeGhEZ++QX22x2xMJLmmDasdvS6/rH/XJN9sN5fraRX5tZkWBVbXnpo= X-Received: by 2002:a17:906:b2c7:: with SMTP id cf7mr10678793ejb.271.1585950247447; Fri, 03 Apr 2020 14:44:07 -0700 (PDT) MIME-Version: 1.0 References: <20200402055640.6677-1-frextrite@gmail.com> <20200402055640.6677-3-frextrite@gmail.com> <20200403075613.GA2788@workstation-portable> <20200403212138.kr72jr57ppzsv6rm@madcap2.tricolour.ca> In-Reply-To: <20200403212138.kr72jr57ppzsv6rm@madcap2.tricolour.ca> From: Paul Moore Date: Fri, 3 Apr 2020 17:43:56 -0400 Message-ID: Subject: Re: [PATCH 3/3 RESEND] auditsc: Do not use RCU primitive to read from cred pointer To: Richard Guy Briggs X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 033LiD1K019707 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Fri, 03 Apr 2020 17:56:08 -0400 Cc: Juri Lelli , Amol Grover , Peter Zijlstra , Ben Segall , Joel Fernandes , Vincent Guittot , James Morris , Madhuparna Bhowmik , Ingo Molnar , Mel Gorman , linux-kernel-mentees@lists.linuxfoundation.org, "Paul E . McKenney" , Jann Horn , Steven Rostedt , Shakeel Butt , Thomas Gleixner , Dietmar Eggemann , David Howells , linux-kernel@vger.kernel.org, linux-audit@redhat.com, "Eric W . Biederman" , Andrew Morton X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Apr 3, 2020 at 5:22 PM Richard Guy Briggs wrote: > On 2020-04-03 13:26, Amol Grover wrote: > > On Thu, Apr 02, 2020 at 08:56:36AM -0400, Paul Moore wrote: > > > On Thu, Apr 2, 2020 at 1:57 AM Amol Grover wrote: > > > > task_struct::cred is only used task-synchronously and does > > > > not require any RCU locks, hence, rcu_dereference_check is > > > > not required to read from it. > > > > > > > > Suggested-by: Jann Horn > > > > Co-developed-by: Joel Fernandes (Google) > > > > Signed-off-by: Joel Fernandes (Google) > > > > Signed-off-by: Amol Grover > > > > --- > > > > kernel/auditsc.c | 15 +++++---------- > > > > 1 file changed, 5 insertions(+), 10 deletions(-) > > > > > > This is the exact same patch I ACK'd back in February, yes? > > > > > > https://lore.kernel.org/linux-audit/CAHC9VhQCbg1V290bYEZM+izDPRpr=XYXakohnDaMphkBBFgUaA@mail.gmail.com > > > > > > > Hi Paul, > > > > That's correct. I've resend the series out of the fear that the first 2 > > patches might've gotten lost as it's been almost a month since I last > > sent them. Could you please ack this again, and if you don't mind could > > you please go through the other 2 patches and ack them aswell? > > Via who's tree are you expecting this will make it upstream? When I asked a similar question back in February the response was basically not the audit tree. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit