From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4A4C2BA19 for ; Wed, 15 Apr 2020 16:07:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDAC421707 for ; Wed, 15 Apr 2020 16:07:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JAdQYXC5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDAC421707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586966844; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UbRdoRg4V2WnKoYaOo8hB00+ruFFYJ9CjAfMEyV6MhA=; b=JAdQYXC5iDuZiPzh3BhVk5D4fy/VoTxUguHaKHFt/H7n9LD01G8Z0b0Ee/NFXbzVhI2lZe j4cB/TTDa5oUsBNwBizvojbalk2Y77Zv2FhMOpBpAGGzH3AYTl5OXB566zrmpSRjyqW7Ks FmbHD54VnMVYfaQOil+p72wd2Y+xkS0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-a7CFrUfANyWpUYT2nGpCIg-1; Wed, 15 Apr 2020 12:07:19 -0400 X-MC-Unique: a7CFrUfANyWpUYT2nGpCIg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05E4A8018A2; Wed, 15 Apr 2020 16:07:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8FFDA098C; Wed, 15 Apr 2020 16:07:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3102E93363; Wed, 15 Apr 2020 16:07:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 03FG7DX3013188 for ; Wed, 15 Apr 2020 12:07:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id D203AF9AB2; Wed, 15 Apr 2020 16:07:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE0DB10F9AD for ; Wed, 15 Apr 2020 16:07:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA3688FF67A for ; Wed, 15 Apr 2020 16:07:10 +0000 (UTC) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-UqZHnazcNB6mZuosqZsrmg-1; Wed, 15 Apr 2020 12:07:07 -0400 X-MC-Unique: UqZHnazcNB6mZuosqZsrmg-1 Received: by mail-ed1-f67.google.com with SMTP id e5so5601109edq.5 for ; Wed, 15 Apr 2020 09:07:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0MLjDM9KsRvMVgG43FusnRuA/V1fF1PP6aJDpeifgKM=; b=UkOpD7Q7ZZYPr++05odK4/zwt/iV1iyEL9X0B04EGHV3RXavlLW4He6Lr52qOSo00I 2+thSXt4fal/uHGLCUmgy2tkP3pW3QWoQ60hLGHQfsJWFVLh23sUqBpWhLY3Io/NF7g7 nBK0TU3nTqvcQ59K3na65iGkU/BX/S4mIma9nAcrgz1IlDhpAkSRCyxIP77Db0G6x0+N cyvwFvrqzYs9YQOj1whavAKofBjZfPTJiHcUD+bEPNXXDVeUJODK8+lfj0X4mMN33e4d AF7ENcEtjBVAlTvHY4y9rXT4gS7AxOXsaPF3JDvDH9DQJhLP4Hmp025oFcuMzfR9G53z yY8A== X-Gm-Message-State: AGi0PuanlGGkO7lleEfYQMoL44dIs+N2a8iIuuiTpQX0odRpcgz4pHOy UQUknXxTQZMPKUeAKccW8tZGboQ9NwcuCRWWQzJrbEAawQ== X-Google-Smtp-Source: APiQypLP8COjvsdYHv4oXFXwMf6J6TP99ygaMw9PYLf1PRivCLwn52/dEdrcmQ4/gmtocLU0XDdyhTYcQV/snRujxWw= X-Received: by 2002:a05:6402:1d1c:: with SMTP id dg28mr23779746edb.135.1586966826498; Wed, 15 Apr 2020 09:07:06 -0700 (PDT) MIME-Version: 1.0 References: <20191128153203.GA23803@workstation-kernel-dev> <20191130020742.GF157739@google.com> <20200415153417.svpbimg66vbeuk7u@madcap2.tricolour.ca> In-Reply-To: <20200415153417.svpbimg66vbeuk7u@madcap2.tricolour.ca> From: Paul Moore Date: Wed, 15 Apr 2020 12:06:55 -0400 Message-ID: Subject: Re: [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer To: Richard Guy Briggs X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 03FG7DX3013188 X-loop: linux-audit@redhat.com Cc: Amol Grover , linux-kernel@vger.kernel.org, linux-audit@redhat.com, Shuah Khan , Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Apr 15, 2020 at 11:34 AM Richard Guy Briggs wrote: > On 2019-11-29 21:07, Joel Fernandes wrote: > > On Thu, Nov 28, 2019 at 09:02:03PM +0530, Amol Grover wrote: > > > add __rcu notation to RCU protected global pointer auditd_conn > > > > Again, please use proper punctuation and captilization. This is unacceptable. > > Please put more effort into changelog. > > > > Otherwise the patch diff itself looks good to me, with the above nit > > corrected, you could add my tag to the next revision: > > > > Reviewed-by: Joel Fernandes (Google) > > > > thanks, > > > > - Joel > > > > > > > > Fixes multiple instances of sparse error: > > > error: incompatible types in comparison expression > > > (different address spaces) > > Amol or Joel: Is there a reproducer recipe for this? The commit which was merged has a slightly better description which may help. commit cb5172d96d16df72db8b55146b0ec00bfd97f079 Author: Amol Grover Date: Mon Dec 2 00:03:48 2019 +0530 audit: Add __rcu annotation to RCU pointer Add __rcu annotation to RCU-protected global pointer auditd_conn. auditd_conn is an RCU-protected global pointer,i.e., accessed via RCU methods rcu_dereference() and rcu_assign_pointer(), hence it must be annotated with __rcu for sparse to report warnings/errors correctly. Fix multiple instances of the sparse error: error: incompatible types in comparison expression (different address spaces) Reviewed-by: Joel Fernandes (Google) Signed-off-by: Amol Grover [PM: tweak subject line] Signed-off-by: Paul Moore -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit