From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4919C83F17 for ; Wed, 30 Aug 2023 16:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693414641; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TXkbRZIKscH1dS7v4tLrR4eu5EALP+H5U8VMkntOv34=; b=G9T8BH7oyeTXw9EgWAma/MG0HtKiXojCSo3zFYjZgvvLy+KiF1WuzjEuAhxnqC1duuhkne dDOWzb+9kOX8R4NULrChKF6OgDbLao6VF3O7Cw7BUMqmF1SKzAD/wq+Mq7jXJ8HDvGCQWm +F6FuxTBNoXirsQkhMls3XqtLTnaL0Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-498-muDInOt8PsuwFmQjYc31Rw-1; Wed, 30 Aug 2023 12:57:18 -0400 X-MC-Unique: muDInOt8PsuwFmQjYc31Rw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50E79800FF5; Wed, 30 Aug 2023 16:57:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84ED81121315; Wed, 30 Aug 2023 16:57:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3B26919465A3; Wed, 30 Aug 2023 16:57:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9A6A31946589 for ; Wed, 30 Aug 2023 15:47:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 41F1E492C18; Wed, 30 Aug 2023 15:47:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3AD68492C14 for ; Wed, 30 Aug 2023 15:47:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E1443806623 for ; Wed, 30 Aug 2023 15:47:04 +0000 (UTC) Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-EeXaUn7xOP2ZE2fJl7ipBQ-1; Wed, 30 Aug 2023 11:46:59 -0400 X-MC-Unique: EeXaUn7xOP2ZE2fJl7ipBQ-1 Received: from [78.30.34.192] (port=45654 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbNPC-002QQ5-L2; Wed, 30 Aug 2023 17:46:57 +0200 Date: Wed, 30 Aug 2023 17:46:53 +0200 From: Pablo Neira Ayuso To: Phil Sutter Subject: Re: [nf PATCH 1/2] netfilter: nf_tables: Audit log setelem reset Message-ID: References: <20230829175158.20202-1-phil@nwl.cc> MIME-Version: 1.0 In-Reply-To: <20230829175158.20202-1-phil@nwl.cc> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mailman-Approved-At: Wed, 30 Aug 2023 16:57:14 +0000 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Guy Briggs , linux-audit@redhat.com, netfilter-devel@vger.kernel.org Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: netfilter.org Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Aug 29, 2023 at 07:51:57PM +0200, Phil Sutter wrote: > Since set element reset is not integrated into nf_tables' transaction > logic, an explicit log call is needed, similar to NFT_MSG_GETOBJ_RESET > handling. > > For the sake of simplicity, catchall element reset will always generate > a dedicated log entry. This relieves nf_tables_dump_set() from having to > adjust the logged element count depending on whether a catchall element > was found or not. Applied, thanks Phil -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit