linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: "linux-audit@redhat.com" <linux-audit@redhat.com>
Subject: Adding support for MAC_TASK_CONTEXTS and MAC_OBJ_CONTEXTS to userspace.
Date: Mon, 14 Jun 2021 12:34:33 -0700	[thread overview]
Message-ID: <e252b332-1a32-2103-f299-d0376b8a4615@schaufler-ca.com> (raw)
In-Reply-To: e252b332-1a32-2103-f299-d0376b8a4615.ref@schaufler-ca.com

I'm looking at the audit userspace implications of adding two
new kernel audit records. AUDIT_MAC_TASK_CONTEXTS and
AUDIT_MAC_OBJ_CONTEXTS are used when there are multiple security
modules with a "security context" active on the system. This
design has been discussed here at length. The records will look
like:

	AUDIT_MAC_TASK_CONTEXTS
	subj_<lsmname>=value
	subj_<lsmname>=value
	...

Looking at the audit user-space code I see several things
that have me concerned. The first is the use of WITH_APPARMOR.
Going forward what behavior would we want if subj_apparmor=something
shows up on a system that has not got WITH_APPARMOR defined?
The code is inconsistent in that it does not use WITH_SELINUX,
but that's hardly a surprise given its origins. There is also no
WITH_SMACK, but that's unlikely to be an issue since Smack's use
of audit is very much like SELinux's. The question is what to
do about filtering when subj=foo is specified. I suggest that if
any of subj_selinux, subj_smack or subj_something is "foo", it is
a match. But the SELinux components of a label (level, user, ...)
are also available for filtering. If someone wrote a simple Bell &
LaPadula LSM filtering by some of those fields could be useful
there, too.

I would like guidance on whether I ought to go the route of
more extensive use of WITH_APPARMOR (and WITH_SMACK, WITH_MUMBLE)
or take the path of greater generalization. Or, whether I should
treat each case individually and give it my best whack.

Thank you.



--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


       reply	other threads:[~2021-06-14 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e252b332-1a32-2103-f299-d0376b8a4615.ref@schaufler-ca.com>
2021-06-14 19:34 ` Casey Schaufler [this message]
2021-06-14 21:13   ` Adding support for MAC_TASK_CONTEXTS and MAC_OBJ_CONTEXTS to userspace Steve Grubb
2021-06-15 17:01     ` Casey Schaufler
2021-06-15 21:15       ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e252b332-1a32-2103-f299-d0376b8a4615@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=linux-audit@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).