linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Coly Li <colyli@suse.de>, axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] bcache: Kconfig dependence fix for NVDIMM support
Date: Mon, 19 Apr 2021 22:36:05 -0700	[thread overview]
Message-ID: <047f5cb5-3084-bc5e-58b3-b3596901066e@infradead.org> (raw)
In-Reply-To: <20210420044452.88267-2-colyli@suse.de>

On 4/19/21 9:44 PM, Coly Li wrote:
> In drivers/md/bcache/Kconfig, setting BCACHE_NVM_PAGES to "selected"
> LIBNVDIMM and DAX is improper. This patch changes to Kconfig dependance
> from "selected" to "depends on" for LIBNVDIMM and DAX.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Coly Li <colyli@suse.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


Thanks.

> ---
>  drivers/md/bcache/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
> index 0996e366ad0b..59999f24d89e 100644
> --- a/drivers/md/bcache/Kconfig
> +++ b/drivers/md/bcache/Kconfig
> @@ -40,7 +40,7 @@ config BCACHE_NVM_PAGES
>  	bool "NVDIMM support for bcache (EXPERIMENTAL)"
>  	depends on BCACHE
>  	depends on PHYS_ADDR_T_64BIT
> -	select LIBNVDIMM
> -	select DAX
> +	depends on LIBNVDIMM
> +	depends on DAX
>  	help
>  	nvm pages allocator for bcache.
> 


-- 
~Randy


  reply	other threads:[~2021-04-20  5:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  4:44 [PATCH 0/2] bcache patches for Linux v5.13 - 3rd wave Coly Li
2021-04-20  4:44 ` [PATCH 1/2] bcache: Kconfig dependence fix for NVDIMM support Coly Li
2021-04-20  5:36   ` Randy Dunlap [this message]
2021-04-20  4:44 ` [PATCH 2/2] bcache: Set error return err to -ENOMEM on allocation failure Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=047f5cb5-3084-bc5e-58b3-b3596901066e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --subject='Re: [PATCH 1/2] bcache: Kconfig dependence fix for NVDIMM support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).