From: Coly Li <colyli@suse.de>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: make kobj_type structures constant
Date: Sat, 15 Apr 2023 22:37:24 +0800 [thread overview]
Message-ID: <0E590AA0-6A76-4816-AF2E-5079CD81A26C@suse.de> (raw)
In-Reply-To: <3c7289e1-2f21-4adc-bed9-df44fd8988d3@t-8ch.de>
> 2023年4月15日 02:38,Thomas Weißschuh <linux@weissschuh.net> 写道:
>
> Hi Coly,
>
> On 2023-04-05 21:38:01+0800, Coly Li wrote:
>>> 2023年4月5日 01:38,Thomas Weißschuh <linux@weissschuh.net> 写道:
>>>
>>> Hi Coly,
>>>
>>> On 2023-02-15 00:16:03+0800, Coly Li wrote:
>>>>> 2023年2月14日 23:21,Thomas Weißschuh <linux@weissschuh.net> 写道:
>>>>>
>>>>> On Tue, Feb 14, 2023 at 05:51:09PM +0800, Coly Li wrote:
>>>>>>
>>>>>>
>>>>>>> 2023年2月14日 11:13,Thomas Weißschuh <linux@weissschuh.net> 写道:
>>>>>>>
>>>>>>> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
>>>>>>> the driver core allows the usage of const struct kobj_type.
>>>>>>>
>>>>>>> Take advantage of this to constify the structure definitions to prevent
>>>>>>> modification at runtime.
>>>>>>>
>>>>>>
>>>>>> How the const structure definition can prevent modification at run time?
>>>>>
>>>>> It will be put into .rodata instead of .data by the compiler.
>>>>> The .rodata section is mapped as read-only via the pagetable.
>>>>>
>>>>> See Documentation/security/self-protection.rst
>>>>> "Function pointers and sensitive variables must not be writable".
>>>>
>>>> I see. Thanks for the information.
>>>>
>>>> This patch will be added into my testing queue, and submitted later.
>>>
>>> It seems this was not submitted.
>>> Or did I miss it?
>>
>> No I don’t submit it yet. It is not emergent fix, and stay with other testing patches together.
>>
>> Do you want it to go now?
>
> No, it's not urgent.
>
> I just assumed it should have been in next by now and thought it got
> lost along the way.
> Let's keep it with the other testing patches.
Some patches from Zheming are not simple, and I need to find time to go through them carefully.
If I am not able to handle them in time, I will submit the simple ones to Jens some time later.
Thanks.
Coly Li
prev parent reply other threads:[~2023-04-15 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 3:13 [PATCH] bcache: make kobj_type structures constant Thomas Weißschuh
2023-02-14 9:51 ` Coly Li
2023-02-14 15:21 ` Thomas Weißschuh
2023-02-14 16:16 ` Coly Li
2023-04-04 17:38 ` Thomas Weißschuh
2023-04-05 13:38 ` Coly Li
2023-04-14 18:38 ` Thomas Weißschuh
2023-04-15 14:37 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E590AA0-6A76-4816-AF2E-5079CD81A26C@suse.de \
--to=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).