linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: Qiaowei Ren <qiaowei.ren@intel.com>, Jianpeng Ma <jianpeng.ma@intel.com>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [RFC PATCH v6 0/7] nvm page allocator for bcache
Date: Mon, 8 Feb 2021 21:49:58 +0800	[thread overview]
Message-ID: <0c4ba429-9697-be06-e5a4-4bd3a07c6275@suse.de> (raw)
In-Reply-To: <20210208142621.76815-1-qiaowei.ren@intel.com>

On 2/8/21 10:26 PM, Qiaowei Ren wrote:
> This series implements nvm pages allocator for bcache. This idea is from
> one discussion about nvdimm use case in kernel together with Coly. Coly
> sent the following email about this idea to give some introduction on what
> we will do before:
> 
> https://lore.kernel.org/linux-bcache/bc7e71ec-97eb-b226-d4fc-d8b64c1ef41a@suse.de/
> 
> Here this series focus on the first step in above email, that is to say,
> this patch set implements a generic framework in bcache to allocate/release
> NV-memory pages, and provide allocated pages for each requestor after reboot.
> In order to do this, one simple buddy system is implemented to manage NV-memory
> pages.
> 
> This set includes one testing module which can be used for simple test cases.
> Next need to stroe bcache log or internal btree nodes into nvdimm based on
> these buddy apis to do more testing.
> 
> Qiaowei Ren (7):
>   bcache: add initial data structures for nvm pages
>   bcache: initialize the nvm pages allocator
>   bcache: initialization of the buddy
>   bcache: bch_nvm_alloc_pages() of the buddy
>   bcache: bch_nvm_free_pages() of the buddy
>   bcache: get allocated pages from specific owner
>   bcache: persist owner info when alloc/free pages.

I test the V6 patch set, it works with current bcache part change. Sorry
for not response for the previous series in time on list, but thank you
all to fix the known issues in previous version.

Although the series is still marked as RFC patches, but IMHO they are in
good shape for an EXPERIMENTAL series.

I will have them with my other bcache changes in the v5.12 for-next, and
it is so far so good in my smoking testing.

There is one thing I feel should be clarified from you, I see some
patches the author and the first signed-off-by person is not identical.
Please make the first SOB people to be the same one in the From/Author
field. And I guess maybe most of the work are done by both of you, if
this is true, the second author can use a Co-authored-by: tag after the
first Signed-off-by: person.

The v6 series is under testing now, so it is unnecessary to post one
more version for the above changes. I'd like to change them from my side
if you may provide me some hints.

Thanks for the contribution, the tiny NVDIMM pages allcoator works.

Coly Li

  reply	other threads:[~2021-02-08 13:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 14:26 [RFC PATCH v6 0/7] nvm page allocator for bcache Qiaowei Ren
2021-02-08 13:49 ` Coly Li [this message]
2021-02-09  2:30   ` Ren, Qiaowei
2021-02-09  3:26     ` Coly Li
2021-02-08 14:26 ` [RFC PATCH v6 1/7] bcache: add initial data structures for nvm pages Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 2/7] bcache: initialize the nvm pages allocator Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 3/7] bcache: initialization of the buddy Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 4/7] bcache: bch_nvm_alloc_pages() " Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 5/7] bcache: bch_nvm_free_pages() " Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 6/7] bcache: get allocated pages from specific owner Qiaowei Ren
2021-02-08 14:26 ` [RFC PATCH v6 7/7] bcache: persist owner info when alloc/free pages Qiaowei Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c4ba429-9697-be06-e5a4-4bd3a07c6275@suse.de \
    --to=colyli@suse.de \
    --cc=jianpeng.ma@intel.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=qiaowei.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).