From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2 09/26] block: Remove some unnecessary bi_vcnt usage Date: Thu, 20 Sep 2012 16:51:59 -0700 Message-ID: <20120920235159.GP7264@google.com> References: <1347322957-25260-1-git-send-email-koverstreet@google.com> <1347322957-25260-10-git-send-email-koverstreet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1347322957-25260-10-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org List-Id: linux-bcache@vger.kernel.org On Mon, Sep 10, 2012 at 05:22:20PM -0700, Kent Overstreet wrote: > More prep work for immutable bvecs/effecient bio splitting - usage of > bi_vcnt has to be auditing, so getting rid of all the unnecessary usage > makes that easier. > > Plus, bio_segments() is really what this code wanted, as it respects the > current value of bi_idx. Looks good to me but definitely need reviews from SCSI people. Thanks. -- tejun